Relative date queries (continuation of #2418) #2597
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added some doc
fixed an error with the weeks that didn't use the sign correctly added more tests, this is where py.test fixtures would shine
corrected rst fixed flake8 in test
corrected docs with correct example added relative date usage to it
The previous version wasn't user-friendly enough and too technical.
A relative date doesn't need to be prefixed by @ anymore. The relative date pattern now displays named groups. Digits have been change to [0-9] to avoid other digit characters. Removed the @ character in tests. Updated subsequent documentation.
Solved conflicts with upstream of new parse classmethod of DateQuery # Conflicts: # beets/dbcore/query.py
don't seem to play well
|
@sampsyo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @discopatrick, @silb and @brunal to be potential reviewers. |
Closed
sampsyo
added a commit
that referenced
this pull request
Jun 15, 2017
To better match #2597 for a cleaner diff.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds relative dates to the query syntax for date-type fields. It's @euri10's work; I'm just opening the pull request to succeed #2418. 馃懟