Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unicode support to IPFS plugin #3015

Closed
wants to merge 1 commit into from
Closed

Conversation

ncryptid
Copy link

I was having an issue with the IPFS plugin not being set to encode to UTF-8 (using the default ASCII encoding in Python) and totally failing to publish if I had any albums in my library that used Unicode characters (e.g. Japanese characters). I added a small workaround to set the default encoding for this plugin to UTF-8.

This is a hacky fix, but I don't think it should really make a difference for a plugin this small. But this is my first pull request ever and I'm a total programming noob so I may have overlooked something.

@sampsyo
Copy link
Member

sampsyo commented Aug 28, 2018

Hi! Sorry, but globally changing the Python interpreter’s encoding will have lots of unintended side-effects for the rest of beets.

What’s the error you’re seeing? We have standard ways to deal with Unicode filenames (c.f. some notes on the Hacking page of the wiki), and seeing a traceback may help us give you suggestions about how to apply them.

@jtpavlock jtpavlock closed this Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants