Add unicode support to IPFS plugin #3015
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was having an issue with the IPFS plugin not being set to encode to UTF-8 (using the default ASCII encoding in Python) and totally failing to publish if I had any albums in my library that used Unicode characters (e.g. Japanese characters). I added a small workaround to set the default encoding for this plugin to UTF-8.
This is a hacky fix, but I don't think it should really make a difference for a plugin this small. But this is my first pull request ever and I'm a total programming noob so I may have overlooked something.