Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hook byte string interpolation #3167

Merged
merged 2 commits into from Feb 25, 2019

Conversation

Projects
None yet
2 participants
@jackwilsdon
Copy link
Member

commented Feb 25, 2019

Fixes #2967.

@jackwilsdon

This comment has been minimized.

Copy link
Member Author

commented Feb 25, 2019

Please ignore the failed continuous-integration/appveyor/branch and continuous-integration/travis-ci/push tests - I've upset Travis and AppVeyor by accidentally pushing the branch to this repository instead of my fork and then deleting the branch I pushed here.

@sampsyo

This comment has been minimized.

Copy link
Member

commented Feb 25, 2019

Looks perfect; thank you!!

Could you please add a quick changelog entry? It also looks like .test_hook.py.swp got committed by mistake—you might want to add .*.swp to your global .gitignore.

@jackwilsdon jackwilsdon force-pushed the jackwilsdon:fix-hook-unicode branch 2 times, most recently from 4a8157a to 0a58773 Feb 25, 2019

@jackwilsdon

This comment has been minimized.

Copy link
Member Author

commented Feb 25, 2019

Oops! Thought I'd already removed that 😖 rookie mistake.

Added a changelog entry and removed the swapfile 👍

@jackwilsdon jackwilsdon force-pushed the jackwilsdon:fix-hook-unicode branch from 0a58773 to c63674c Feb 25, 2019

jackwilsdon added some commits Feb 25, 2019

@jackwilsdon jackwilsdon force-pushed the jackwilsdon:fix-hook-unicode branch from c63674c to 25549a6 Feb 25, 2019

@sampsyo

This comment has been minimized.

Copy link
Member

commented Feb 25, 2019

Looks perfect; thank you!!

@sampsyo sampsyo merged commit f6ad98a into beetbox:master Feb 25, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.