Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hook byte string interpolation #3167

Merged
merged 2 commits into from Feb 25, 2019
Merged

Fix hook byte string interpolation #3167

merged 2 commits into from Feb 25, 2019

Conversation

jackwilsdon
Copy link
Member

Fixes #2967.

@jackwilsdon jackwilsdon mentioned this pull request Feb 25, 2019
Closed
@jackwilsdon
Copy link
Member Author

Please ignore the failed continuous-integration/appveyor/branch and continuous-integration/travis-ci/push tests - I've upset Travis and AppVeyor by accidentally pushing the branch to this repository instead of my fork and then deleting the branch I pushed here.

@sampsyo
Copy link
Member

sampsyo commented Feb 25, 2019

Looks perfect; thank you!!

Could you please add a quick changelog entry? It also looks like .test_hook.py.swp got committed by mistake—you might want to add .*.swp to your global .gitignore.

@jackwilsdon jackwilsdon force-pushed the fix-hook-unicode branch 2 times, most recently from 4a8157a to 0a58773 Compare February 25, 2019 14:38
@jackwilsdon
Copy link
Member Author

Oops! Thought I'd already removed that 😖 rookie mistake.

Added a changelog entry and removed the swapfile 👍

@sampsyo
Copy link
Member

sampsyo commented Feb 25, 2019

Looks perfect; thank you!! ✨

@sampsyo sampsyo merged commit f6ad98a into beetbox:master Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jackwilsdon @sampsyo