Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpd: extend coverage of MPD protocol #3200

Merged
merged 23 commits into from Apr 2, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
de6718a
bpd: separate tests by command category
arcresu Apr 1, 2019
d94a539
bpd: fix crossfade command
arcresu Mar 30, 2019
0f53ae9
bpd: error instead of crashing on extra argument
arcresu Mar 30, 2019
1511e31
bpd: add mixramp commands
arcresu Mar 30, 2019
67a0b38
bpd: add dummy command for volume
arcresu Mar 30, 2019
e585186
bpd: add replay_gain_* commands
arcresu Mar 30, 2019
859e16d
bpd: support consume command
arcresu Mar 30, 2019
71e7621
bpd: no-op support for persistent playlists
arcresu Apr 1, 2019
bae9c40
bpd: support the single command
arcresu Apr 1, 2019
b245c0e
bpd: test fields returned by status command
arcresu Apr 1, 2019
0c3a63e
bpd: fix repeat mode behaviour
arcresu Apr 1, 2019
a4fe687
bpd: fix bug in bounds check of current song index
arcresu Apr 1, 2019
12e49b3
bpd: skipping backwards through zero keeps playing
arcresu Apr 1, 2019
146c5f5
bpd: fix repeat, consume and single in reverse
arcresu Apr 1, 2019
e839e4e
bpd: improve exception handling
arcresu Apr 1, 2019
9622e74
bpd: return real audio data
arcresu Apr 1, 2019
36c85a8
Fix beets.util.inspect for Python 3
arcresu Apr 1, 2019
4be2e1b
Remove beets.util.inspect wrapper
arcresu Apr 1, 2019
28db7d3
bpd: provide precision time in status
arcresu Apr 2, 2019
d074dac
bpd: add comments to the error handling code
arcresu Apr 2, 2019
20e2f8b
bpd: output an info-level message when ready
arcresu Apr 2, 2019
140d25d
Changelog for #3200
arcresu Apr 2, 2019
95dd513
bpd: add flake8 exception for test command
arcresu Apr 2, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 6 additions & 3 deletions beets/plugins.py
Expand Up @@ -19,14 +19,14 @@

import traceback
import re
import inspect
from collections import defaultdict
from functools import wraps


import beets
from beets import logging
from beets import mediafile
from beets.util import inspect
import six

PLUGIN_NAMESPACE = 'beetsplug'
Expand Down Expand Up @@ -127,7 +127,10 @@ def _set_log_level_and_params(self, base_log_level, func):
value after the function returns). Also determines which params may not
be sent for backwards-compatibility.
"""
argspec = inspect.getargspec(func)
if six.PY2:
func_args = inspect.getargspec(func).args
else:
func_args = inspect.getfullargspec(func).args

@wraps(func)
def wrapper(*args, **kwargs):
Expand All @@ -142,7 +145,7 @@ def wrapper(*args, **kwargs):
if exc.args[0].startswith(func.__name__):
# caused by 'func' and not stuff internal to 'func'
kwargs = dict((arg, val) for arg, val in kwargs.items()
if arg in argspec.args)
if arg in func_args)
return func(*args, **kwargs)
else:
raise
Expand Down
50 changes: 0 additions & 50 deletions beets/util/inspect.py

This file was deleted.