Crash-resilient Tekstowo lyrics source #3995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous code had the potential to crash if (when?) Tekstowo changes their website structure sufficiently. The new code is rather ugly due to the explicit checks after each and every function call. Unfortunately, the alternative would be to catch a bunch of very generic Exceptions (AttributeError, ...), since there's no such thing as a `BeautifulSoupNotFoundError`.
wisp3rwind
force-pushed
the
pr_lyrics_tekstowo_no_crashes
branch
from
31062d5
to
0c28575
Compare
|
This looks perfect. It's one of those cases where "monadic" handling of Nones would actually be useful… but in any case, this seems like the right thing to do! Thanks!!! |
That's a concept I've only been confronted with pretty recently, but I didn't recognize the pattern here, so thanks for pointing it out! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #3994, see the comments there, and the message for the second commit in this PR: