Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

beetsplug/web: fix translation of query path #4182

Merged
merged 1 commit into from
Jan 6, 2022

Commits on Jan 6, 2022

  1. beetsplug/web: fix translation of query path

    The routing map translator `QueryConverter` was misconfigured:
    * decoding (parsing a path): splitting with "/" as tokenizer
    * encoding (translating back to a path): joining items with "," as separator
    
    This caused queries containing more than one condition (separated by a
    slash) to return an empty result.  Queries with only a single condition
    were not affected.
    
    Instead the encoding should have used the same delimiter (the slash) for the
    backward conversion.
    
    How to reproduce:
    * query: `/album/query/albumartist::%5Efoo%24/original_year%2B/year%2B/album%2B`
    * resulting content in parsed argument `queries` in the `album_query` function:
        * previous (wrong): `['albumartist::^foo$,original_year+,year+,album+']`
        * new (correct): `['albumartist::^foo$', 'original_year+', 'year+', 'album+']`
    sumpfralle committed Jan 6, 2022
    Configuration menu
    Copy the full SHA
    a09c804 View commit details
    Browse the repository at this point in the history