Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change bpm to be a float (instead of int) field #4734

Closed
wants to merge 3 commits into from

Conversation

baelany
Copy link

@baelany baelany commented Mar 27, 2023

Description

Fixes issue #4298 .
To address the feature outlined in issue #4298, we modified beets/library.py and beetsplug/bpm.py to have bpm support float type instead of integer type. We locally tested our changes by making modifications to test/test_beatport.py and test/test_query.py.

To Do

  • Documentation. (If you've add a new command-line flag, for example, find the appropriate page under docs/ to describe it.)
  • Changelog. (Add an entry to docs/changelog.rst near the top of the document.)
  • Tests. (Encouraged but not strictly required.)

@sampsyo
Copy link
Member

sampsyo commented Apr 1, 2023

Thank you for getting this going!!

This is a somewhat sensitive change, so we will want to proceed with caution. In particular, there are two potential pitfalls on my mind:

  • If someone has an existing library with a bunch of integer bpm values, will using that database with the new version of beets cause any problems?
  • We will want to change MediaFile to use float also. Will it cause any problems for the two to temporarily disagree on the type of the field? Or do we need to make a coordinated change—updating MediaFile, releasing a new version, and changing beets' dependencies to require the updated version of MediaFile before release?

I would love any help thinking through these issues in detail!

@stale
Copy link

stale bot commented Aug 10, 2023

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 10, 2023
@stale stale bot closed this Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants