Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FetchArt : fix an error with CAA where the pre-sized thumbs of release groups would be ignored #4940

Conversation

AdrienCos
Copy link
Contributor

@AdrienCos AdrienCos commented Oct 7, 2023

Description

This patch fixes two bugs with the Cover Art Archive provider of the FetchArt plugin:

  • the pre-sized thumbnails of the release group of an album would be ignored when the maxwidth option matches one of the available sizes (250, 500, and 1200 pixels).
    • This allows the release group to behave exactly like the release itself (which does take the pre-sized thumbnails into account).
  • no cover would be found and downloaded when the maxsize option is defined, is in the pre-sized thumbnails list, but CAA does not provide thumbnails for this release/release group

This patch can significantly speed up the fetching process of some albums, as the default size of some cover arts can be quite large (e.g. this cover is 56 MB and 7300 pixels wide, while the 1200px version is 450KB).

This patch also add a section in the FetchArt plugin documentation, detailing this behavior.

To Do

  • Documentation. (If you've add a new command-line flag, for example, find the appropriate page under docs/ to describe it.)
  • Changelog. (Add an entry to docs/changelog.rst near the top of the document.)
  • Tests. (Encouraged but not strictly required.)

@AdrienCos AdrienCos changed the title Fix the error with CAA where the pre-sized thumbs of release groups Would be ignored Fix the error with CAA where the pre-sized thumbs of release groups would be ignored Oct 7, 2023
@AdrienCos AdrienCos changed the title Fix the error with CAA where the pre-sized thumbs of release groups would be ignored FetchArt : fix an error with CAA where the pre-sized thumbs of release groups Would be ignored Oct 7, 2023
@AdrienCos AdrienCos changed the title FetchArt : fix an error with CAA where the pre-sized thumbs of release groups Would be ignored FetchArt : fix an error with CAA where the pre-sized thumbs of release groups would be ignored Oct 7, 2023
@AdrienCos AdrienCos force-pushed the fix/fetchart-caa-use-maxwidth-presized-thumbs branch from 5fa5d4f to 96b89e7 Compare October 7, 2023 21:14
Copy link
Member

@sampsyo sampsyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!! This looks really handy. Thanks for the clean fix, and for extending the documentation to match. When/if the CI goes green, this looks ready to merge.

@Serene-Arc Serene-Arc merged commit 821e629 into beetbox:master Oct 14, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants