Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix changelog workflow #5231

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

snejus
Copy link
Member

@snejus snejus commented May 7, 2024

Use pull_request_target event for the changelog update reminder

See https://github.com/marketplace/actions/comment-pull-request#permissions for more details.

Additionally, refactor the workflow into a more canonical form utilising the tj-actions/changed-files GitHub action.

snejus added 2 commits May 7, 2024 16:28
See https://github.com/marketplace/actions/comment-pull-request#permissions
for more details.

Additionally, refactor the workflow into a more canonical form utilising
the `tj-actions/changed-files` GitHub action.
@snejus snejus self-assigned this May 7, 2024
@snejus snejus requested a review from wisp3rwind May 7, 2024 15:28
@wisp3rwind
Copy link
Member

So, I'm definitely not an expert on Github actions at all. At a superficial glance, this looks reasonable.

Is pulling in the tj-actions/changed-files action necessary to make this work independent of the source of the PR? Or would the old git diff solution also work?

@snejus
Copy link
Member Author

snejus commented May 8, 2024

So, I'm definitely not an expert on Github actions at all. At a superficial glance, this looks reasonable.

Is pulling in the tj-actions/changed-files action necessary to make this work independent of the source of the PR? Or would the old git diff solution also work?

Nope - it's not necessary. That's just an extra nice to have

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants