Remove flake8 docstrings and its exclusion rules #5234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snejus
force-pushed
the
remove-flake8-docstrings-and-its-exclusion-rules
branch
from
8596e7d
to
fa788e2
Compare
|
So that point is that we're not enforcing this at all, so there's no point in even having the check; is that correct? |
Indeed. |
|
Adding to that, it's removing a rule that enforces a practice from a defunct practice. Since that's the case, and we're not even really using it, I think it can be removed. Merge when you want @snejus |
Serene-Arc
approved these changes
Jun 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have come across this interesting case since I submitted a PR with an edit in a file that falls out of these exclusion rules: #5233 . 馃榿