Fix for #4709

[arogl]

Description

Fixes #4709.

Changelog to complete if testing works out

To Do

• Changelog. (Add an entry to docs/changelog.rst to the bottom of one of the lists near the top of the document.)

[arogl]

Doing further testng with #5235 enabled on windows to compare failures

[arogl]

I also noted the runners for python 3.x DO NOT run any tests apart from mypy 😢 they have been excluded.

They also no longer test the next beta version.

[arogl]

Thsi should be good of further tetsing before merging.
I'll try out on Ubuntu 24.04 (WSL), and teh latest version of as much as possible

[wisp3rwind]

I also noted the runners for python 3.x DO NOT run any tests apart from mypy 😢 they have been excluded.

They also no longer test the next beta version.

yes, I realized the same yesterday, we should revisit our CI first. I also remember that we used to have a run for the next Python alpha; we should bring that back: In particular, we already know that Python 3.13 is going to break beets due to the imghdr removal.

[arogl]

Tested on fully updated Arch and Ubuntu-24.04 with #5235 set with DQS=0|1

[snejus]

May be worth to consider replacing this entire thing with something like

        order = "ASC" if self.ascending else "DESC"
        collate = "COLLATE NOCASE" if self.case_insensitive else ""

        return f"COALESCE(NULLIF({self.field}_sort, ''), {self.field}) {collate} {order}"

[snejus]

While you're here it may be good to replace this with

Suggested change

	.execute("select year from items where title='the title'")
	.execute("select year from items where title = ?", (i.title,))

Same applies to the rest of the updates. the title is taken out of context and it isn't clear whether the query is looking for the item that has just been stored or some other one

[arogl]

@snejus All tests use hardcoded values, so the suggested (i.title,) did not work.

[snejus]

See slightly below, this pattern is being used here for example

    def test_albuminfo_for_two_items_doesnt_duplicate_row(self):
        i2 = item(self.lib)
        self.lib.get_album(self.i)
        self.lib.get_album(i2)

        c = self.lib._connection().cursor()
        c.execute("select * from albums where album=?", (self.i.album,))
        # Cursor should only return one row.

Just checked this test in question, and realised I made a typo. It should instead be

            .execute("select year from items where title = ?", (self.i.title,))

The test works fine on my end.

[arogl]

Updated to user passed values rather than hard coded values