Fixed menu bug (#292) #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! Any chance you could provide before / after screen shots? |
|
@phildini You should be able to verify this by checking current website behavior vs the netlify deploy preview (one of the pre-build checks) |
|
Hello @phildini Here is the link for the netlify deploy preview |
phildini
approved these changes
Mar 4, 2021
|
@phildini Thank you for merging my code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed some CSS properties to fix the menu bug, so that the user can scroll down the menu and change to another language.
The menu position was fixed, so it can't be scrolled (hiding bottom items)
We can't change to another language due to the dropdown menu opening mostly out of the bottom of the screen.
But now it can be scrolled and we can access bottom items and also change to another language using the dropdown.
This PR Fixes #292
PR Checklist: