Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide user a more informative error when a git clone fails #1210

Merged
merged 6 commits into from
Apr 24, 2023

Conversation

rmblau
Copy link
Contributor

@rmblau rmblau commented Apr 24, 2023

This change provides the user with a more informative error message and a solution when the git clone fails.

When a user runs briefcase create and the clone fails, a ValueError is raised. To a newcomer the error is non obvious what the root cause is. This change provides an explicit error and a solution to resolve the error.

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks!

Co-authored-by: Russell Martin <rmartin16@gmail.com>
@freakboy3742 freakboy3742 merged commit 27e5532 into beeware:main Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants