Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump JDK from 17.0.8.1+1 to 17.0.10+7 #1611

Merged
merged 1 commit into from Jan 18, 2024
Merged

Conversation

rmartin16
Copy link
Member

@rmartin16 rmartin16 commented Jan 18, 2024

Changes

  • Bumps JDK from 17.0.8.1+1 to 17.0.10+7
  • Adds a test to ensure the JDK URL is resolvable

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@rmartin16 rmartin16 marked this pull request as ready for review January 18, 2024 16:34
Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice touch with the URL verification. My immediate reaction was to be nervous that the test suite was dependent on a network connection, but a HEAD request is as lightweight as it can get.

Might be worth adding analogous tests for other downloaded artefacts (like the Android bootstrap, RCEdit, etc).

@freakboy3742 freakboy3742 merged commit 7d8fd58 into beeware:main Jan 18, 2024
44 checks passed
@rmartin16 rmartin16 deleted the bump-jdk branch January 25, 2024 17:25
@rmartin16 rmartin16 mentioned this pull request Jan 25, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants