Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test download URLs for tools #1618

Merged
merged 1 commit into from Jan 29, 2024
Merged

Conversation

rmartin16
Copy link
Member

@rmartin16 rmartin16 commented Jan 25, 2024

Changes

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@rmartin16
Copy link
Member Author

FWIW, this noticeably, but not significantly, impacts the runtime for the tests.

Anecdata:

> tox -e py
Before: 37.58=setup[1.17]+cmd[36.42] seconds
After:  41.94=setup[1.21]+cmd[40.73] seconds

> tox -e py-fast
Before: 7.46=setup[1.21]+cmd[6.25] seconds
After:  8.09=setup[1.16]+cmd[6.93] seconds

Slowest tests:

0.36s call     tests/integrations/subprocess/test_Subprocess__stream_output.py::test_keyboard_interrupt
0.29s call     tests/test_mainline.py::test_unknown_command_error
0.28s call     tests/integrations/android_sdk/AndroidSDK/test_properties.py::test_cmdline_tools_url[Linux-x86_64-linux]
0.27s call     tests/integrations/java/test_JDK__verify.py::test_successful_jdk_download[Darwin-x86_64-https://github.com/adoptium/temurin17-binaries/releases/download/jdk-17.0.10+7/OpenJDK17U-jdk_x64_mac_hotspot_17.0.10_7.tar.gz-java17/Contents/Home-False]
0.23s call     tests/integrations/android_sdk/AndroidSDK/test_properties.py::test_cmdline_tools_url[Darwin-x86_64-mac]
0.22s call     tests/integrations/java/test_JDK__verify.py::test_successful_jdk_download[Darwin-arm64-https://github.com/adoptium/temurin17-binaries/releases/download/jdk-17.0.10+7/OpenJDK17U-jdk_aarch64_mac_hotspot_17.0.10_7.tar.gz-java17/Contents/Home-False]
0.22s call     tests/integrations/java/test_JDK__verify.py::test_successful_jdk_download[Linux-armv8l-https://github.com/adoptium/temurin17-binaries/releases/download/jdk-17.0.10+7/OpenJDK17U-jdk_arm_linux_hotspot_17.0.10_7.tar.gz-java17-False]
0.21s call     tests/integrations/java/test_JDK__verify.py::test_successful_jdk_download[Linux-x86_64-https://github.com/adoptium/temurin17-binaries/releases/download/jdk-17.0.10+7/OpenJDK17U-jdk_x64_linux_hotspot_17.0.10_7.tar.gz-java17-False]
0.21s call     tests/integrations/java/test_JDK__verify.py::test_successful_jdk_download[Linux-armv7l-https://github.com/adoptium/temurin17-binaries/releases/download/jdk-17.0.10+7/OpenJDK17U-jdk_arm_linux_hotspot_17.0.10_7.tar.gz-java17-False]
0.21s call     tests/integrations/java/test_JDK__verify.py::test_successful_jdk_download[Linux-aarch64-https://github.com/adoptium/temurin17-binaries/releases/download/jdk-17.0.10+7/OpenJDK17U-jdk_aarch64_linux_hotspot_17.0.10_7.tar.gz-java17-False]
0.21s call     tests/integrations/java/test_JDK__verify.py::test_successful_jdk_download[Windows-AMD64-https://github.com/adoptium/temurin17-binaries/releases/download/jdk-17.0.10+7/OpenJDK17U-jdk_x64_windows_hotspot_17.0.10_7.zip-java17-False]
0.21s call     tests/test_mainline.py::test_interrupted_command_with_log
0.21s call     tests/integrations/java/test_JDK__verify.py::test_successful_jdk_download[Linux-aarch64-https://github.com/adoptium/temurin17-binaries/releases/download/jdk-17.0.10+7/OpenJDK17U-jdk_arm_linux_hotspot_17.0.10_7.tar.gz-java17-True]
0.19s call     tests/integrations/linuxdeploy/test_LinuxDeployQtPlugin__properties.py::test_download_url[Linux-x86_64-x86_64]
0.19s call     tests/integrations/linuxdeploy/test_LinuxDeploy__properties.py::test_download_url[Linux-i686-i386]
0.19s call     tests/integrations/linuxdeploy/test_LinuxDeployQtPlugin__properties.py::test_download_url[Darwin-x86_64-x86_64]
0.19s call     tests/integrations/android_sdk/AndroidSDK/test_properties.py::test_cmdline_tools_url[Darwin-arm64-mac]
0.19s call     tests/integrations/wix/test_WiX__verify.py::test_download_wix
0.19s call     tests/integrations/rcedit/test_RCEdit__properties.py::test_rcedit_url
0.19s call     tests/integrations/android_sdk/AndroidSDK/test_properties.py::test_cmdline_tools_url[Windows-AMD64-win]
0.18s call     tests/integrations/linuxdeploy/test_LinuxDeploy__properties.py::test_download_url[Darwin-x86_64-x86_64]
0.18s call     tests/integrations/linuxdeploy/test_LinuxDeployQtPlugin__properties.py::test_download_url[Linux-i686-i386]
0.18s call     tests/integrations/linuxdeploy/test_LinuxDeploy__properties.py::test_download_url[Linux-x86_64-x86_64]
0.17s teardown tests/platforms/windows/visualstudio/test_run.py::test_run_app_test_mode_with_args
0.17s call     tests/integrations/subprocess/test_Subprocess__stream_output.py::test_readline_raises_exception
0.13s call     tests/console/test_Log.py::test_save_log_to_file_with_multiple_exceptions
0.11s call     tests/integrations/linuxdeploy/test_LinuxDeployGtkPlugin__properties.py::test_download_url
0.11s call     tests/platforms/linux/appimage/test_build.py::test_build_appimage[True]
0.10s call     tests/integrations/subprocess/test_Subprocess__stream_output.py::test_filter_func_output_and_stop_iteration

@rmartin16 rmartin16 marked this pull request as ready for review January 25, 2024 23:12
Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good improvement to me. Yes, the tests are slower, but not to a degree that I find concerning; and they won't work offline, but that's an increasingly rare (and manageable) problem.

@freakboy3742 freakboy3742 merged commit 61e8c66 into beeware:main Jan 29, 2024
44 checks passed
@rmartin16 rmartin16 deleted the url-tests branch January 29, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants