Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a cancel button on test discovery failure, so we can cleanly abort #5

Merged
merged 1 commit into from
Jul 8, 2013

Conversation

stephenmcd
Copy link
Contributor

Hey Russell,

This is really cool, thanks for releasing it.

One issue I had was that I haphazardly first ran the django module in a directory without a Django project. This triggers an error dialogue with a retry button which is all well and good, but there was no obvious way to quit out of this scenario - even Ctrl C on the terminal failed and I couldn't escape without kill -9ing the process.

My change adds a cancel button to the error dialogue, which gets overridden for TestLoadErrorDialog to shut down the whole app.

Thanks again!

Steve

@thsutton
Copy link

thsutton commented Jul 8, 2013

Does this not lead to an error as the app ends?

_tkinter.TclError: can't invoke "toplevel" command:  application has been destroyed

@stephenmcd
Copy link
Contributor Author

Yes I did receive that error, but wasn't sure how to surpress it. First time touching tkinter here :-)

@thsutton
Copy link

thsutton commented Jul 8, 2013

I had the same response. :-)

freakboy3742 added a commit that referenced this pull request Jul 8, 2013
Add a cancel button on test discovery failure, so we can cleanly abort
@freakboy3742 freakboy3742 merged commit 704d98d into beeware:master Jul 8, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants