Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor dialog implementation #1948

Merged
merged 4 commits into from
May 24, 2023
Merged

Conversation

freakboy3742
Copy link
Member

In the process of auditing WebView, I noticed an opportunity for code reuse in Dialog.

This refactors the Dialogs implementation so that:

  1. There's a clear interface/impl separation for dialog objects
  2. There's a full interface/_impl/native chain. This should make dialog testing simpler (hopefully?)
  3. The asynchronous result capability is factored out as a base class that can be re-used

Testing regimen for this is the dialogs example.

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@freakboy3742 freakboy3742 requested a review from mhsmith May 24, 2023 02:02
@mhsmith mhsmith merged commit 1920542 into beeware:main May 24, 2023
@freakboy3742 freakboy3742 deleted the dialog-impl branch May 25, 2023 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants