add implementation for set.remove()

beeware · Nov 20, 2016 · ccb1c34 · ccb1c34
1 parent 53dd179
commit ccb1c34
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 3 deletions.
diff --git a/python/common/org/python/types/Set.java b/python/common/org/python/types/Set.java
@@ -434,10 +434,14 @@ public org.python.Object pop() {
     }
 
     @org.python.Method(
-        __doc__ = ""
+        __doc__ = "Remove an element from a set; it must be a member.\n\nIf the element is not a member, raise a KeyError.",
+        args = {"item"}
     )
-    public org.python.Object remove(org.python.Object other) {
-        throw new org.python.exceptions.NotImplementedError("remove() has not been implemented.");
+    public org.python.Object remove(org.python.Object item) {
+        if (!this.value.remove(item)) {
+            throw new org.python.exceptions.KeyError(item);
+        }
+        return org.python.types.NoneType.NONE;
     }
 
     @org.python.Method(

diff --git a/tests/datatypes/test_set.py b/tests/datatypes/test_set.py
@@ -108,6 +108,14 @@ def test_intersection(self):
             print(z)
             """)
 
+    def test_remove(self):
+        self.assertCodeExecution("""
+            x = {1, 2, 3}
+            x.remove(1)
+            x.remove(4)
+            print(x)
+            """)
+
 
 class UnarySetOperationTests(UnaryOperationTestCase, TranspileTestCase):
     data_type = 'set'