Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relax requirements of convertFromString #34

Closed
v-lopez opened this issue Dec 11, 2018 · 2 comments
Closed

relax requirements of convertFromString #34

v-lopez opened this issue Dec 11, 2018 · 2 comments

Comments

@v-lopez
Copy link
Contributor

v-lopez commented Dec 11, 2018

Don't fail compilation, send a warning instead

facontidavide added a commit that referenced this issue Dec 11, 2018
@facontidavide
Copy link
Collaborator

@mjeronimo for your information:

I decided to be less strict regarding convertFromString.

Now the program will compile even if the template specialization is missing.
If the NodeParameter points to a Blackboard, everything will work just fine since no string parsing is needed.

If either:

  • NodeParameter was actually a string, not a pointer to a Blackboard entry or
  • The Blackboard entry contains a string and you are trying to extract something else.

an exception is thrown, warning that you must implement your own convertFromString.

@mjeronimo
Copy link

@facontidavide Sounds reasonable. Thanks for the info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants