Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSVC x64 warnings C4334: '<<' : result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?) #146

Closed
cpeterso opened this issue Oct 18, 2015 · 3 comments
Closed

MSVC x64 warnings C4334: '<<' : result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?) #146

cpeterso opened this issue Oct 18, 2015 · 3 comments

Comments

@cpeterso
Copy link
Contributor

I see the following MSVC x64 compiler warnings when building harfbuzz (as part of Firefox) for Win64. MSVC is complaining about #define FLAG_SAFE(x) (1U << (x)).

harfbuzz/src/hb-ot-shape-complex-indic.cc(240) : warning C4334: '<<' : result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?)
harfbuzz/src/hb-ot-shape-complex-indic.cc(250) : warning C4334: '<<' : result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?)
harfbuzz/src/hb-ot-shape-complex-indic.cc(966) : warning C4334: '<<' : result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?)
harfbuzz/src/hb-ot-shape-complex-indic.cc(1518) : warning C4334: '<<' : result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?)
harfbuzz/src/hb-ot-shape-complex-indic.cc(1672) : warning C4334: '<<' : result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?)
harfbuzz/src/hb-ot-shape-complex-indic.cc(1819) : warning C4334: '<<' : result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?)
@behdad behdad closed this as completed in 50e5750 Oct 21, 2015
@behdad
Copy link
Member

behdad commented Oct 21, 2015

Thanks. Can you test the fix?

@cpeterso
Copy link
Contributor Author

Works for me. You have fixed all the Win64 warnings! :-)

I will submit a patch to update Firefox's HarfBuzz snapshot soon.

@behdad
Copy link
Member

behdad commented Oct 27, 2015

Great!

gpgreen pushed a commit to gpgreen/harfbuzz that referenced this issue Jan 10, 2024
Auto merge of harfbuzz#146 - spl:expand-travis, r=jdm
6c442b9 
Create test matrix for Travis-CI

This change significantly increases the surface area tested on Travis. It includes a few notable changes, namely `touch hb-version.*` and `harfbuzz-sys-test/build.rs`, that allow various tests to pass. It also adds `cargo test` and `cargo package`.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-harfbuzz/146)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@behdad @cpeterso