Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't rely on .cluster in _hb_ot_shape_normalize() #124

Closed
wants to merge 1 commit into from
Closed

Don't rely on .cluster in _hb_ot_shape_normalize() #124

wants to merge 1 commit into from

Conversation

jfkthame
Copy link
Collaborator

@jfkthame jfkthame commented Aug 7, 2015

@behdad
Copy link
Member

behdad commented Aug 7, 2015

lgtm. Please merge. Can you add a micro-test as well?

@jfkthame
Copy link
Collaborator Author

jfkthame commented Aug 7, 2015

I don't have a suitable checkout & dev environment set up to create micro-tests ATM, was hoping you might be able to add those, thx.

@behdad
Copy link
Member

behdad commented Aug 7, 2015

Will do. Thanks.
On Aug 7, 2015 7:24 PM, "jfkthame" notifications@github.com wrote:

I don't have a suitable checkout & dev environment set up to create
micro-tests ATM, was hoping you might be able to add those, thx.

—
Reply to this email directly or view it on GitHub
#124 (comment).

@behdad
Copy link
Member

behdad commented Aug 9, 2015

It's hard to generate test for this. So I just merged manually.

@jfkthame jfkthame closed this in c7dfe31 Aug 9, 2015
@behdad behdad deleted the normalize-patch1 branch September 8, 2016 18:36
gpgreen pushed a commit to gpgreen/harfbuzz that referenced this pull request Jan 10, 2024
Auto merge of harfbuzz#124 - waywardmonkeys:language-copy-clone, r=mb…
baa6bb6 
…rubeck

Make Language Copy/Clone.

This also fixes a clippy warning.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-harfbuzz/124)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jfkthame @behdad