Add support for the OpenType MATH table. #326
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behdad
reviewed
Sep 26, 2016
| hb_ot_layout_t * layout = hb_ot_layout_from_face (face); | ||
|
|
||
| // If the MATH table is not loaded yet, do it now. | ||
| if (!layout->math_blob) { |
There was a problem hiding this comment.
This is not threadsafe. You need to use hb_atomic_ptr_get() and hb_atomic_ptr_cmpexch() instead.
There was a problem hiding this comment.
Also, do the atomic check on layout->math, not layout->math_blob.
| */ | ||
|
|
||
| HB_EXTERN hb_bool_t | ||
| hb_ot_layout_has_math_data (hb_face_t *face); |
| test_ot_layout_math_LDADD = $(LDADD) | ||
| test_ot_layout_math_CPPFLAGS = $(AM_CPPFLAGS) | ||
| test_ot_layout_math_CPPFLAGS += $(FREETYPE_CFLAGS) | ||
| test_ot_layout_math_LDADD += $(FREETYPE_LIBS) |
There was a problem hiding this comment.
Merge these four lines into two.
|
This is mostly merged into my math branch now. |
|
It would be great to rebase d776da2 too later, using the new API for mathvariant. http://frederic-wang.fr/opentype-math-in-harfbuzz.html |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.