Minor refactoring to the atomics implementation #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For most cases, the GCC/Intel atomics (__sync functions) are fine, but there are some systems for which libgcc is incorrectly built and thus configure reports HAVE_INTEL_ATOMIC_PRIMITIVES even though the Intel atomics aren't really implemented (i.e. QNX 6.5). As of now, it is possible to implement the atomics in config.h and define HB_NO_ATOMIC_IMPL to force HB use *that* implementation.
Just to bring it in par with the hb_atomic-s.
s/atomic_int/atomic_int_impl/ and s/atomic_ptr/atomic_ptr_impl/ to bring it in par with hb_mutex_impl_t, then re-introduce hb_atomic_int_t as a wrapper around hb_atomic_int_impl_t. In hb_reference_count_t, make it clear the non-atomic get and set are intentional due to nature of the cases they are used in (comparison to -1 and the debug output/tracing).
|
Thanks. I implemented the first two commits in a different way. |
|
Thanks. I merged this after minor changes. Please check. |
|
LGTM so far. Thanks. |
|
missing HB_ATOMIC_INT_IMPL_INIT definition in |
|
Fixed. Thanks. |
gpgreen
pushed a commit
to gpgreen/harfbuzz
that referenced
this pull request
Jan 10, 2024
Derive Clone rather than impl it. This fixes warnings under clippy, but also happily makes it match how current bindgen generates code, which will reduce some diffs that will be coming up. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-harfbuzz/92) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.