Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JGRP-1740] Fix byteman tests on Windows. #114

Closed

Conversation

rachmatowicz
Copy link
Collaborator

See this issue for details: https://issues.jboss.org/browse/JGRP-1740

@belaban
Copy link
Owner

belaban commented Nov 28, 2013

This failed:
[linux]/home/bela/JGroups$ java -version
java version "1.6.0_43"
Java(TM) SE Runtime Environment (build 1.6.0_43-b01)
Java HotSpot(TM) 64-Bit Server VM (build 20.14-b01, mixed mode)
[linux]/home/bela/JGroups$ ant byteman
Buildfile: /home/bela/JGroups/build.xml

keyStoreGenerated:

check-jars-exist:

check-ivy-exists:

get-ivy:

define-ivy-task:

retrieve:

prepare:

compile:

makeKeystore:

postcompile:

define-testng-task:

byteman:
[testng] Error occurred during initialization of VM
[testng] agent library failed to init: instrument
[testng] Error opening zip file or JAR manifest missing : /home/bela/JGroups/lib/byteman.jar
[testng] The tests failed.

@belaban
Copy link
Owner

belaban commented Nov 28, 2013

The correct JAR is byteman-2.1.3.jar, but I don't want to hard code this in build.xml...

@rachmatowicz
Copy link
Collaborator Author

Hmm, this reminds me of a discrepancy I found when testing on Windows. Before you moved to ivy, you used to include byteman.jar and byteman-version.jar in lib. Once you moved to ivy, the non-versioned jars are no longer present. I was going to add a step to ivy to recreate the aliasing, but know zero about ivy. Would that be a way around this issue?

@rachmatowicz
Copy link
Collaborator Author

I've added a small ant task instance to make a copy of byteman-version.jar to byteman.jar which should fix the problem.

WDYT?

@belaban
Copy link
Owner

belaban commented Dec 12, 2013

I applied the removal of 'scripts' from the dir and adding it to the classpath. However, I don't want to apply the kludge to locate the byteman JAR just because this doesn't work on Windoze. We have to find a better way.

@belaban belaban closed this Dec 12, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants