JGRP-1992 GOOGLE_PING discovery fails if port 443 isn't used #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change GOOGLE_PING to use port 443 when creating a connection and no port is specified in the configuration.
belaban
added a commit
that referenced
this pull request
Dec 10, 2015
JGRP-1992 GOOGLE_PING discovery fails if port 443 isn't used
|
Thanks for the fix, Alan. Did you test this with a real GCE account, or did you use some simulator? |
|
I tested this with a real GCE account, Bela. |
|
OK. I read that there is a Google Cloud server that can be run off of the local file system to check a client's correctness. |
|
That would be interesting. Do you have a link with more information? |
|
Thanks a lot, Bela |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change GOOGLE_PING to use port 443 when creating a connection and no
port is specified in the configuration.