Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JGRP-2631 Multi-Release JAR #650

Merged
merged 1 commit into from
Aug 2, 2022

Conversation

tristantarrant
Copy link
Collaborator

@tristantarrant tristantarrant commented Aug 1, 2022

@rhusar
Copy link
Collaborator

rhusar commented Aug 1, 2022

I have added JDK 19 to the test matrix - #651 - can you just rebase and push your branch? (Unfortunately that's how GH Actions work).

* Thread/Executor creation delegated to a JDK-specific class
@tristantarrant
Copy link
Collaborator Author

done

@tristantarrant
Copy link
Collaborator Author

Looking at the JDK 19 build, everything is ok:

[INFO] --- maven-compiler-plugin:3.10.1:compile (default-compile) @ jgroups ---
[INFO] Compiling 464 source files to /home/runner/work/JGroups/JGroups/target/classes
[INFO] /home/runner/work/JGroups/JGroups/src/org/jgroups/protocols/Locking.java: Some input files use or override a deprecated API.
[INFO] /home/runner/work/JGroups/JGroups/src/org/jgroups/protocols/Locking.java: Recompile with -Xlint:deprecation for details.
[INFO] /home/runner/work/JGroups/JGroups/src/org/jgroups/util/SecurityActions.java: Some input files use or override a deprecated API that is marked for removal.
[INFO] /home/runner/work/JGroups/JGroups/src/org/jgroups/util/SecurityActions.java: Recompile with -Xlint:removal for details.
[INFO] /home/runner/work/JGroups/JGroups/src/org/jgroups/stack/Protocol.java: Some input files use unchecked or unsafe operations.
[INFO] /home/runner/work/JGroups/JGroups/src/org/jgroups/stack/Protocol.java: Recompile with -Xlint:unchecked for details.
[INFO] 
[INFO] --- maven-compiler-plugin:3.10.1:compile (jdk-19) @ jgroups ---
[INFO] Compiling 1 source file to /home/runner/work/JGroups/JGroups/target/classes/META-INF/versions/19
[INFO] /home/runner/work/JGroups/JGroups/mr/19/src/org/jgroups/util/jdkspecific/ThreadCreator.java: /home/runner/work/JGroups/JGroups/mr/19/src/org/jgroups/util/jdkspecific/ThreadCreator.java uses preview features of Java SE 19.
[INFO] /home/runner/work/JGroups/JGroups/mr/19/src/org/jgroups/util/jdkspecific/ThreadCreator.java: Recompile with -Xlint:preview for details.

I guess the release should be done with JDK 19 in order to have the bits in.

@tristantarrant
Copy link
Collaborator Author

@belaban do you want me to change the source directory for JDK 19 ?

@tristantarrant
Copy link
Collaborator Author

Also, the logs should probably be i18n'ized

@belaban
Copy link
Owner

belaban commented Aug 2, 2022

No, it's fine. I'm changing build.xml, as it doesn't currently include the mr classes (the POM works fine)

@tristantarrant
Copy link
Collaborator Author

Note: it is always better to use -release instead of -source/-target because it ensures that API signature compatibility is maintained.

@belaban belaban merged commit 388eb8f into belaban:master Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants