(finally) Improve formatting of InvocationExpressions

[belav]

Some examples

                var extension = GetExtensionForLanguageType(
                    (FrontEndResourceLanguage)Enum.Parse(
                        typeof(FrontEndResourceLanguage),
                        this.Language));

            this.Address1 = addressFields.FirstOrDefault(
                field => field.FieldName == "Address1");

// Invocation inside IfStatement
            if (customerOrder == null || !customerOrder.FulfillmentMethod.EqualsIgnoreCase(
                FulfillmentMethod.PickUp.ToString()))

[belav]

Printing InvocationExpressions well for all the variations looks like it will be a lot of work. See https://github.com/prettier/prettier/blob/main/src/language-js/print/member-chain.js for how complex it could get.

[belav]

I made some progress on formatting simpler cases than the ones above.

Here is another one that needs some work

        this.Address1 = addressFields.Where(
                field => field.FieldName == "Address1")
            .Where(field => yeah)
            .Where(field => yeah);

[belav]

More examples

    roleNames
        .ToList()
        .ForEach((role) =>
            this.adminContextMock
                .Setup((ctx) => ctx.IsUserInRole(role))
                .Returns(false)
        );

[belav]

This will require conditionalGroup, run it in prettier to see how they do it.

        var superLongMethodNameForceLine = someFactoryName
            .SuperLongMethodNameForceLine()
            .SomeOtherReallyLongMethodName();

[belav]

Another edge case

    var linePosition________________________ = diagnostics[
            i
        ].Location.GetLineSpan().StartLinePosition;

[belav]

this seems like extra indentation

            var compilation = await project.WithCompilationOptions(compilationOptions)
                    .GetCompilationAsync();

[belav]

Possibly already covered above with the diagnostics[ edge case

                AttributeCollection attributes = TypeDescriptor.GetProperties(modelType)[
                        propertyName
                    ].Attributes;

                JsonIgnoreAttribute jsonIgnoreAttribute = (JsonIgnoreAttribute)attributes[
                        typeof(JsonIgnoreAttribute)
                    ];

[belav]

And

            string signedRequest = htmlHelper.ViewContext.HttpContext.Request.Params[
                "signed_request"
            ];

[belav]

This is related, but I think it's actually an ImplicitObjectCreationExpression

public static readonly HardLine HardLineIfNoPreviousLineSkipBreakIfFirstInGroup = new(
    true,
    true);

[belav]

Another edge case

result[i / ReferenceFrameSize] = RenderTreeFrame.ComponentReferenceCapture(
    0,
    null,
    0
);
// should be
result[i / ReferenceFrameSize] = 
    RenderTreeFrame.ComponentReferenceCapture(0, null, 0);

[belav]

Another example

        Diagnostic.Create(
            _descriptor,
            symbolForDiagnostic.DeclaringSyntaxReferences.FirstOrDefault()?.GetSyntax()
                .GetLocation()
                ?? Location.None,
            symbol.ToDisplayString(SymbolDisplayFormat.CSharpShortErrorMessageFormat)
        );

[belav]

Another example

                if (
                    endpoints[
                        i
                    ].Metadata.GetMetadata<DynamicControllerRouteValueTransformerMetadata>() != null
                ) {

[belav]

This appears to have extra indentation because of the Invocation

            return value == null
                ? CallMethod(
                          value.ToString(),
                          "([a-z])([A-Z])",
                          "$1-$2",
                          RegexOptions.None,
                          TimeSpan.FromMilliseconds(100)
                      )
                      .ToLowerInvariant()
                : Regex.Replace(
                          value.ToString(),
                          "([a-z])([A-Z])",
                          "$1-$2",
                          RegexOptions.None,
                          TimeSpan.FromMilliseconds(100)
                      )
                      .ToLowerInvariant();

[belav]

            FacebookGroupConnection<TStatus> statuses = await GetFacebookObjectAsync<
                FacebookGroupConnection<TStatus>
            >(client, "me/statuses");
// should maybe be
            FacebookGroupConnection<TStatus> statuses = 
                await GetFacebookObjectAsync<FacebookGroupConnection<TStatus>>(
                    client,
                    "me/statuses"
                );

[belav]

This used to be more lines, but more readable, maybe it should go back.

            var proxy1 =
                generator.CreateInterfaceProxyWithTargetInterface<IEventHandler<EventArgs1>>(
                    null,
                    new[] { lazyInterceptor1 }
                );
// is now
            var proxy1 = generator.CreateInterfaceProxyWithTargetInterface<
                IEventHandler<EventArgs1>
            >(null, new[] { lazyInterceptor1 });

[belav]

This may be related

// used to be
            var ex = Assert.Throws<ArgumentException>(
                () =>
                    generator.CreateInterfaceProxyWithTargetInterface<IList<IList<PrivateInterface>>>(
                        new List<IList<PrivateInterface>>(),
                        new IInterceptor[0]
                    )
            );
// is now
            var ex = Assert.Throws<ArgumentException>(
                () =>
                    generator.CreateInterfaceProxyWithTargetInterface<
                        IList<IList<PrivateInterface>>
                    >(new List<IList<PrivateInterface>>(), new IInterceptor[0])
            );

[belav]

These are a bunch of edge cases that are probably related

 // these used to not break so weird
            ref var parentFrame = ref diffContext.NewTree[
                newFrame.ComponentReferenceCaptureParentFrameIndexField
            ];

            var newComponentInstance = (CaptureSetParametersComponent)oldTree.GetFrames().Array[
                0
            ].Component;

            parent = (ContainerNode)parent.Children[
                childIndexAtCurrentDepth + siblingIndex
            ];

            configuration.EncryptionAlgorithmKeySize = (int)encryptionElement.Attribute(
                "keyLength"
            )!;

// used to break onto the next line
            var cbTempSubkeys = checked(
                _symmetricAlgorithmSubkeyLengthInBytes + _hmacAlgorithmSubkeyLengthInBytes
            );
// but then this looks better with checked next to =
            var cbEncryptedData = checked(
                cbCiphertext
                - (
                    KEY_MODIFIER_SIZE_IN_BYTES
                    + _symmetricAlgorithmBlockSizeInBytes
                    + _hmacAlgorithmDigestLengthInBytes
                )
            );
            
// used to be 2 lines
            var cacheKey = (
                ModelType: fieldIdentifier.Model.GetType(),
                fieldIdentifier.FieldName
            );

// this is better, but still looks weird
        public AccessTokenNotAvailableException(
            NavigationManager navigation,
            AccessTokenResult tokenResult,
            IEnumerable<string> scopes
        ) : base(
            message: "Unable to provision an access token for the requested scopes: " + scopes
            != null
                ? $"'{string.Join(", ", scopes ?? Array.Empty<string>())}'"
                : "(default scopes)"
        ) {

// this is just gross, it used to break parameters instead of generic types
            var count = (int)await _invoker.InvokeUnmarshalled<
                string[],
                object?,
                object?,
                Task<object>
            >(GetSatelliteAssemblies, culturesToLoad.ToArray(), null, null);

// not sure what to do with this
                storedArguments[i] = localVariables[i] = Expression.Parameter(
                    parameters[i].ParameterType
                );