Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strong Name Assemblies #911

Closed
TwentyFourMinutes opened this issue Jun 11, 2023 · 2 comments
Closed

Strong Name Assemblies #911

TwentyFourMinutes opened this issue Jun 11, 2023 · 2 comments
Milestone

Comments

@TwentyFourMinutes
Copy link

TwentyFourMinutes commented Jun 11, 2023

I am trying to use the Csharpier.Core package in a signed project. However I do get runtime exception for Csharpier.Core as it is not signed:

Referenced assembly 'CSharpier, Version=0.24.2.0, Culture=neutral, PublicKeyToken=null' does not have a strong name.

In essence to fix this create a .snk file and enter the following command in a Developer Command Prompt for VS:

sn -k csharpier.snk

Move the file to the same location as the Directory.Build.props and add the following inside the Directory.Build.props file:

<AssemblyOriginatorKeyFile>$(MSBuildThisFileDirectory)/csharpier.snk</AssemblyOriginatorKeyFile>
<SignAssembly>true</SignAssembly>

Would be an easy fix and doesn't hurt anyone :)

@belav belav added this to the 0.25.0 milestone Jun 12, 2023
@belav
Copy link
Owner

belav commented Jun 12, 2023

I have this basically done but ran into https://www.nuget.org/packages/Ignore not being signed. It is a small library under MIT so I'll pull in the couple of files that I need to finish this off.

@TwentyFourMinutes
Copy link
Author

Oh, I see. If you want to offload any work, feel free to tell me. Thanks for looking into it though!

belav added a commit that referenced this issue Jun 13, 2023
belav added a commit that referenced this issue Jun 13, 2023
belav added a commit that referenced this issue Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants