Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CLI message regarding directoryOrFile #1297

Merged
merged 4 commits into from
Jun 28, 2024
Merged

Fix CLI message regarding directoryOrFile #1297

merged 4 commits into from
Jun 28, 2024

Conversation

marcinjahn
Copy link
Contributor

Closes #1296

@shocklateboy92
Copy link
Collaborator

@belav is this accurate?
I thought a dummy path was required even when piping stdin.

@belav
Copy link
Owner

belav commented Jun 28, 2024

@belav is this accurate? I thought a dummy path was required even when piping stdin.

This PR is accurate, looks like the help text never got updated when piping stdin was added.
Code that enforces directoryOrFile

Thanks @marcinjahn !

@belav belav merged commit 7ab89d5 into belav:main Jun 28, 2024
3 checks passed
pisolofin pushed a commit to pisolofin/csharpier-editorconfig that referenced this pull request Aug 1, 2024
@marcinjahn @pisolofin
Fix CLI message regarding directoryOrFile (belav#1297)
8e44b45 
Closes belav#1296
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@belav belav belav approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The CLI has contradictory message about directoryOrFile being required
3 participants
@marcinjahn @shocklateboy92 @belav