Update sentry integ to official sentry/nextjs #1409
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). nextjs-monorepo-example-blog-app – ./apps/blog-app🔍 Inspect: https://vercel.com/belgattitude/nextjs-monorepo-example-blog-app/G7e58P1SrPT7b5XapJwwo4ZVsBtq nextjs-monorepo-example-web-app – ./apps/web-app🔍 Inspect: https://vercel.com/belgattitude/nextjs-monorepo-example-web-app/BxEm4FZbNaYh2pegHN6xJJMgBNC6 nextjs-monorepo-example-vite-app – ./apps/vite-app🔍 Inspect: https://vercel.com/belgattitude/nextjs-monorepo-example-vite-app/GBQfdLqMetANqzJWHTwepTJiJHpu |
🦋 Changeset detectedLatest commit: 790dda3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Code Climate has analyzed commit 790dda3 and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
CodeSee Review Map:Review in an interactive map View more CodeSee Maps Legend |
# Conflicts: # apps/web-app/package.json # yarn.lock
# Conflicts: # apps/web-app/package.json # yarn.lock
6 months ago, @sentry/nextjs was included in #216... Had to revert it and go back to traditional webpack aliasing.
Has it changed since ?
Size increase (tested without swc to be sure)
a 30kb increase when moving from
@sentry/browser+@sentry/nodeto@sentry/nextjs. Had to increase the size-limit check. Probably due to automatic inclusion of sentry tracing. Compare: treemap without sentry/nextjs with @sentry/nextjsI could gain back 30kb when changing the import
sentry.browser.config.tsto '@sentry/react' rather than '@sentry/nextjs`Blocked by
check:install with @yarnpkg/doctor fails, ref sentry/nextjs warning on install about missing webpack getsentry/sentry-javascript#4632 and fix(nextjs): webpack as optional peer-dependency getsentry/sentry-javascript#4634.Monitor pages
In server side: with vercel the custom error page can't be displayed if a non success http status code is send (need to look for a solution).