Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nextjs): webpack as optional peer-dependency #4634

Merged
merged 1 commit into from
Feb 25, 2022
Merged

fix(nextjs): webpack as optional peer-dependency #4634

merged 1 commit into from
Feb 25, 2022

Conversation

belgattitude
Copy link
Contributor

@belgattitude belgattitude commented Feb 24, 2022 •
edited

Should close #4632

  • fix a warning about a missing peer-dep on webpack.
  • should fix install with yarn pnp / pnpm modules linkers

Notes

This was referenced Feb 24, 2022
Closed
Merged
@AbhiPrasad AbhiPrasad mentioned this pull request Feb 24, 2022
Closed
@AbhiPrasad
Copy link
Member

Hey thanks for opening a PR. We're currently discussing this in #4635, feedback welcome!

@AbhiPrasad AbhiPrasad changed the title chore(sentry/nextjs): webpack as optional peer-dependency fix(nextjs): webpack as optional peer-dependency Feb 25, 2022
@AbhiPrasad
Copy link
Member

Let's go with this for now, and re-evaluate as needed. Thanks for the help!

@AbhiPrasad AbhiPrasad merged commit ad76379 into getsentry:master Feb 25, 2022
@AbhiPrasad AbhiPrasad mentioned this pull request Feb 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sentry/nextjs warning on install about missing webpack
2 participants
@belgattitude @AbhiPrasad