Update Go version to 1.18.4

Update Go version to 1.18.4, update linter config and version, also
fix all lint issues reported.

Closes elastic#25

.github/workflows/golangci-lint.yml

@@ -26,24 +26,24 @@ jobs:
            GOOS: ${{ matrix.GOOS }}
         run: echo Go GOOS=$GOOS
 
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
 
       # Uses Go version from the repository.
       - name: Read .go-version file
         id: goversion
         run: echo "::set-output name=version::$(cat .go-version)"
 
-      - uses: actions/setup-go@v2
+      - uses: actions/setup-go@v3
         with:
           go-version: "${{ steps.goversion.outputs.version }}"
 
       - name: golangci-lint
         env:
           GOOS: ${{ matrix.GOOS }}
-        uses: golangci/golangci-lint-action@v2
+        uses: golangci/golangci-lint-action@v3
         with:
           # Optional: version of golangci-lint to use in form of v1.2 or v1.2.3 or `latest` to use the latest version
-          version: v1.44.2
+          version: v1.45.2
 
           # Give the job more time to execute.
           # Regarding `--whole-files`, the linter is supposed to support linting of changed a patch only but,
@@ -52,10 +52,9 @@ jobs:
           # which can lead to some frustration from developers who would like to
           # fix a single line in an existing codebase and the linter would force them
           # into fixing all linting issues in the whole file instead.
-          args: --timeout=30m --whole-files
-
-          # Optional: if set to true then the action will use pre-installed Go.
-          skip-go-installation: true
+          args: --timeout=30m --whole-files -c ./.golangci.yml
 
           # Optional: show only new issues if it's a pull request. The default value is `false`.
           only-new-issues: true
+
+          skip-cache: true

.go-version

@@ -1 +1 @@
-1.17.12
+1.18.4

.golangci.yml

@@ -4,17 +4,23 @@
 # options for analysis running
 run:
   # timeout for analysis, e.g. 30s, 5m, default is 1m
-  timeout: 1m
+  timeout: 15m
 
 issues:
   # Maximum count of issues with the same text.
   # Set to 0 to disable.
   # Default: 3
-  max-same-issues: 0
+  max-same-issues: 3
   # Maximum issues count per one linter.
   # Set to 0 to disable.
   # Default: 50
-  max-issues-per-linter: 0
+  max-issues-per-linter: 50
+  exclude-rules:
+    # Exclude package name contains '-' issue because we have at least one package with
+    # it on its name.
+    - text: "ST1003:"
+      linters:
+        - stylecheck
 
 output:
   sort-results: true
@@ -36,7 +42,6 @@ linters:
     - goconst # finds repeated strings that could be replaced by a constant
     - dupl # tool for code clone detection
     - forbidigo # forbids identifiers	matched by reg exps
-    - gomoddirectives # manage the use of 'replace', 'retract', and 'excludes' directives in go.mod.
     - gosimple # linter for Go source code that specializes in simplifying a code
     - misspell # finds commonly misspelled English words in comments
     - nakedret # finds naked returns in functions greater than a specified function length
@@ -98,13 +103,24 @@ linters-settings:
     # Exclude godoc examples from forbidigo checks.  Default is true.
     exclude_godoc_examples: true
 
-  gomoddirectives:
-    # Allow local `replace` directives. Default is false.
-    replace-local: false
+  goimports:
+    local-prefixes: github.com/elastic
+
+  gomodguard:
+    blocked:
+      # List of blocked modules.
+      modules:
+        # Blocked module.
+        - github.com/pkg/errors:
+            # Recommended modules that should be used instead. (Optional)
+            recommendations:
+              - errors
+              - fmt
+            reason: "This package is deprecated, use `fmt.Errorf` with `%w` instead"
 
   gosimple:
     # Select the Go version to target. The default is '1.13'.
-    go: "1.17.12"
+    go: "1.18.4"
 
   misspell:
     # Correct spellings using locale preferences for US or UK.
@@ -129,38 +145,22 @@ linters-settings:
     # Enable to ensure that nolint directives are all used. Default is true.
     allow-unused: false
     # Disable to ensure that nolint directives don't have a leading space. Default is true.
-    allow-leading-space: true
+    allow-leading-space: false
     # Exclude following linters from requiring an explanation.  Default is [].
     allow-no-explanation: []
     # Enable to require an explanation of nonzero length after each nolint directive. Default is false.
     require-explanation: true
     # Enable to require nolint directives to mention the specific linter being suppressed. Default is false.
-    require-specific: true
-
-  gomodguard:
-    blocked:
-      # List of blocked modules.
-      modules:
-        # Blocked module.
-        - github.com/pkg/errors:
-            # Recommended modules that should be used instead. (Optional)
-            recommendations:
-              - errors
-              - fmt
-            reason: "This package is deprecated"
-        - github.com/elastic/beats/v7:
-            reason: "There must be no Beats dependency"
+    require-specific: false
 
   staticcheck:
     # Select the Go version to target. The default is '1.13'.
-    go: "1.17.12"
-    # https://staticcheck.io/docs/options#checks
+    go: "1.18.4"
     checks: ["all"]
 
   stylecheck:
     # Select the Go version to target. The default is '1.13'.
-    go: "1.17.12"
-    # https://staticcheck.io/docs/options#checks
+    go: "1.18.4"
     checks: ["all"]
 
   unparam:
@@ -172,4 +172,4 @@ linters-settings:
 
   unused:
     # Select the Go version to target. The default is '1.13'.
-    go: "1.17.12"
+    go: "1.18.4"

CHANGELOG-developer.md

@@ -10,6 +10,8 @@ This project adheres to [Semantic Versioning](http://semver.org/).
 
 ### Changed
 
+- Update Go to 1.18.4
+
 ### Deprecated
 
 ### Removed

pkg/manager/input/input-cursor/store.go

@@ -22,13 +22,14 @@ import (
 	"sync"
 	"time"
 
+	"go.uber.org/atomic"
+
 	"github.com/elastic/elastic-agent-inputs/pkg/statestore"
 	"github.com/elastic/elastic-agent-inputs/pkg/statestore/cleanup"
 	"github.com/elastic/elastic-agent-libs/logp"
 	"github.com/elastic/elastic-agent-libs/transform/typeconv"
 	"github.com/elastic/go-concert"
 	"github.com/elastic/go-concert/unison"
-	"go.uber.org/atomic"
 )
 
 // store encapsulates the persistent store and the in memory state store, that

pkg/manager/input/input.go

@@ -20,11 +20,11 @@ package input
 import (
 	"time"
 
+	"github.com/gofrs/uuid"
+
 	"github.com/elastic/elastic-agent-inputs/pkg/publisher"
 	conf "github.com/elastic/elastic-agent-libs/config"
 	"github.com/elastic/elastic-agent-libs/logp"
-	"github.com/gofrs/uuid"
-
 	"github.com/elastic/go-concert/unison"
 )
 

pkg/publisher/acker/acker.go

@@ -20,8 +20,9 @@ package acker
 import (
 	"sync"
 
-	"github.com/elastic/elastic-agent-inputs/pkg/publisher"
 	"go.uber.org/atomic"
+
+	"github.com/elastic/elastic-agent-inputs/pkg/publisher"
 )
 
 // Nil creates an ACKer that does nothing.

pkg/publisher/acker/acker_test.go

@@ -21,8 +21,9 @@ package acker
 import (
 	"testing"
 
-	"github.com/elastic/elastic-agent-inputs/pkg/publisher"
 	"github.com/stretchr/testify/require"
+
+	"github.com/elastic/elastic-agent-inputs/pkg/publisher"
 )
 
 type fakeACKer struct {