Support cookies in http ldap connections (#237)

[airosa]

Support cookies in http ldap connections.

We have been running code from then forked package since beginning of the year and we have not seen issues related to this patch.

closes #237

[airosa]

Really nice integration test!

I looked briefly at the output and it looks like this change could be breaking the kerberos authentication support when using HTTP - bummer! We are using kerberos+binary and simple+http so I have not tested this combination before.

Here are the lines that I saw erroring out - they point out that the cookie has a problem:

2024-05-17T03:43:09,512  INFO [HiveServer2-HttpHandler-Pool: Thread-61] thrift.ThriftHttpServlet: Could not validate cookie sent, will try to generate a new cookie
2024-05-17T03:43:09,516 ERROR [HiveServer2-HttpHandler-Pool: Thread-61] thrift.ThriftHttpServlet: Failed to authenticate with hive/_HOST kerberos principal

[airosa]

I changed the approach a bit and as a mitigation it now just deduplicates the request cookies before the request is sent. The cookies are not reset any more when the cursor is closed.

The deduplication is done in the following Go http "roundtripper" (https://pkg.go.dev/net/http#RoundTripper)

type CookieDedupTransport struct {
	http.RoundTripper
}

// RoundTrip removes duplicate cookies (cookies with the same name) from the request
// This is a mitigation for the issue where Hive/Impala cookies get duplicated in the response
func (d *CookieDedupTransport) RoundTrip(req *http.Request) (*http.Response, error) {
	cookieMap := map[string]string{}
	for _, cookie := range req.Cookies() {
		cookieMap[cookie.Name] = cookie.Value
	}

	req.Header.Set("Cookie", "")

	for key, value := range cookieMap {
		req.AddCookie(&http.Cookie{Name: key, Value: value})
	}

	resp, err := d.RoundTripper.RoundTrip(req)

	return resp, err
}

The roundtripper is added to the http client in the getHTTPClient function.

httpClient.Transport = &CookieDedupTransport{httpClient.Transport}

[beltran]

Thank you for writing this PR and following up on the failing test.