Specs for Resolve #4

SwinX · 2015-06-08T11:30:29Z

Resolved #3

Added basic tests covering input params processing, dependency ordering and exceptions on retain cycles.

…Contains 1 pending dummy for now.

…est (jshint does not allow unused params). Removed 'common' context from tests.

…r to tests run correctly. Implemented basic tests for resolve method - covering input params checking behavior, blocks include order, exceptions on cyclic dependencies detection

SwinX · 2015-06-08T11:32:32Z

Resolve comment was not included since this PR is not resolving #3 completely

…ties

…ch in entity can depend on another entity. Added spec describing tech in entity can depend on tech in another entity

…. Added tests about ignorance of tech dependencies if tech is not specified and about tech dependency for specified tech must be placed into entities list

…to entities list

…ies same with resolving tech

…n into anonymous function

…ist test

…tech being resolved

…tech being resolved when ordering set

…being resolved should be ignored

blond · 2015-06-10T21:44:27Z

lib/deps.js

@@ -0,0 +1,7 @@
+/**


Такие коментарии не нужны.

blond · 2015-06-10T22:14:38Z

Все тесты нужно разделить по группам, чтобы удобнее было читать:

про обработку ошибоку
про сборку без технологий
про технологии
про порядок, который надо сохранить
про приоритеты
и т.д.

blond · 2015-06-10T22:29:19Z

test/resolve.test.js

+            deps = [
+                {
+                    entity: { block: 'C' },
+                    dependOn: {


Тут должен быть всегда массив.

…ult if they depend on each other and no explicit ordering set

…ech tests: as result asserts readability improved

…dencies

…included once

… detection to index-in-variable style: readability improved

SwinX · 2015-06-19T15:22:33Z

Переписал тесты на новый ассертер chai, разбил тесты про рекомендуемый и явный порядок на две группы, дополнил разные группы тестов новыми тестами, подшаманил читаемость тестов о порядке включения. Нужно ещё одно ревью от @blond

blond · 2015-06-20T17:04:15Z

package.json

    "matcha": "0.6.0",
    "mocha": "2.2.5",
-    "must": "0.12.0"
+    "chai": "3.0.0"


Напоминаю, что зависимости лучше ставить через npm i chai -D, чтобы порядок в package.json был правильный.

blond · 2015-06-20T18:07:39Z

После chai стало читаться лучше.

Написал немного замечаний. Становится сложно ревьювить из-за кол-ва кейсов: сложно понять каких кейсов не хватает.

Давай начнём думать на какие разделы поделить кейсы. Можно оформить отдельными задачими. На каждый такой раздел свой отдельный PR. Начинать лучше с самых простой и очевидной группы кейсов.

SwinX · 2015-07-07T12:04:41Z

All tests from this PR were already merged in another PRs.
Closed.

SwinX added 5 commits June 5, 2015 12:39

Removed test/fake.test.js stub from project

07a1e68

Added test/resolve.test.js which will contain tests for resolve API. …

08dc64b

…Contains 1 pending dummy for now.

Added deps module, for now contains empty resolve function

e939b53

Removed params from resove function mock in order to be able to run t…

caec8ef

…est (jshint does not allow unused params). Removed 'common' context from tests.

Replaced returning null with returning {} in deps method stub in orde…

abd2f20

…r to tests run correctly. Implemented basic tests for resolve method - covering input params checking behavior, blocks include order, exceptions on cyclic dependencies detection

SwinX assigned blond Jun 8, 2015

SwinX added 19 commits June 9, 2015 11:30

Added spec describing single entity may depend on multiple other enti…

a101d36

…ties

Fixed typo in cyclic dependencies test description

85577bf

Added spec describing entity depend on itself

ef1765c

Added spec describing ability to build deps list for specific tech

4c25c07

Fixed name for specific tech resolving test. Added test describing te…

f0a941f

…ch in entity can depend on another entity. Added spec describing tech in entity can depend on tech in another entity

Fixed expected result for dependencies between two techs allowed test…

2c1b5b9

…. Added tests about ignorance of tech dependencies if tech is not specified and about tech dependency for specified tech must be placed into entities list

Fixed expected output in tech depend on tech test

ddf44fd

Adjusted description for test about tech dependency should be placed …

8adcaea

…to entities list

Added test for case that resolve should keep order for tech dependenc…

d1d9607

…ies same with resolving tech

Added test about tech can depend on several techs

fe77b91

Removed unused data from itself dependency test

856fa08

Fixed usage of throw command of must library - wrapped tested functio…

e494c67

…n into anonymous function

Fixed usage of throw assertation method in should not process empty l…

1ad6c20

…ist test

Reduced decl in should include all blocks listed in decl test

c4f2ae7

Reduced decl in resolve should keep order test

d572d1f

Added test for intermediate dependencies

a4ae356

Added test resolve should ignore tech dependencies not matching with …

5b6b4a3

…tech being resolved

Added test resolve should ignore tech dependencies not matching with …

53b4c0f

…tech being resolved when ordering set

Reduced decl in tests about tech dependencies not matching with tech …

a16aa38

…being resolved should be ignored

blond reviewed Jun 10, 2015
View reviewed changes

lib/deps.js

@@ -0,0 +1,7 @@

/**

Copy link

Member

blond Jun 10, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Такие коментарии не нужны.

blond reviewed Jun 10, 2015
View reviewed changes

test/resolve.test.js

deps = [

{

entity: { block: 'C' },

dependOn: {

Copy link

Member

blond Jun 10, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Тут должен быть всегда массив.

SwinX added 8 commits June 19, 2015 15:37

Added spec describing entites from decl will not be reordered by defa…

1e04708

…ult if they depend on each other and no explicit ordering set

Extracted indicies locating into separate variables in ordering non-t…

c9d0d3c

…ech tests: as result asserts readability improved

Added test desribing dependency can depend on another entity

2e4e414

Added test describing dependency can depend on multiple other entities

126e138

Added tests describing recommended ordering for dependencies of depen…

a8a916c

…dencies

added test checking if multiple entities depend on entity it will be …

e65f349

…included once

Added test describing implicit cyclic dependencies must be ignored

d0d0f7c

Switched tests working with entities indicies style from inline index…

b5813bf

… detection to index-in-variable style: readability improved

blond reviewed Jun 20, 2015
View reviewed changes

blond changed the title ~~Issue 3~~ Specs for Resolve Jun 21, 2015

blond removed their assignment Jun 21, 2015

blond added the ready label Jun 21, 2015

SwinX closed this Jul 7, 2015

SwinX removed the ready label Jul 7, 2015

blond deleted the issue-3 branch December 2, 2015 22:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Specs for Resolve #4

Specs for Resolve #4

SwinX commented Jun 8, 2015

SwinX commented Jun 8, 2015

blond Jun 10, 2015

blond commented Jun 10, 2015

blond Jun 10, 2015

SwinX commented Jun 19, 2015

blond Jun 20, 2015

blond commented Jun 20, 2015

SwinX commented Jul 7, 2015

Specs for Resolve #4

Specs for Resolve #4

Conversation

SwinX commented Jun 8, 2015

SwinX commented Jun 8, 2015

blond Jun 10, 2015

Choose a reason for hiding this comment

blond commented Jun 10, 2015

blond Jun 10, 2015

Choose a reason for hiding this comment

SwinX commented Jun 19, 2015

blond Jun 20, 2015

Choose a reason for hiding this comment

blond commented Jun 20, 2015

SwinX commented Jul 7, 2015