-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specs for Resolve #4
Conversation
…Contains 1 pending dummy for now.
…est (jshint does not allow unused params). Removed 'common' context from tests.
…r to tests run correctly. Implemented basic tests for resolve method - covering input params checking behavior, blocks include order, exceptions on cyclic dependencies detection
Resolve comment was not included since this PR is not resolving #3 completely |
…ch in entity can depend on another entity. Added spec describing tech in entity can depend on tech in another entity
…. Added tests about ignorance of tech dependencies if tech is not specified and about tech dependency for specified tech must be placed into entities list
…ies same with resolving tech
…n into anonymous function
…tech being resolved
…tech being resolved when ordering set
…being resolved should be ignored
@@ -0,0 +1,7 @@ | |||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Такие коментарии не нужны.
Все тесты нужно разделить по группам, чтобы удобнее было читать:
|
deps = [ | ||
{ | ||
entity: { block: 'C' }, | ||
dependOn: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Тут должен быть всегда массив.
…ult if they depend on each other and no explicit ordering set
…ech tests: as result asserts readability improved
… detection to index-in-variable style: readability improved
Переписал тесты на новый ассертер chai, разбил тесты про рекомендуемый и явный порядок на две группы, дополнил разные группы тестов новыми тестами, подшаманил читаемость тестов о порядке включения. Нужно ещё одно ревью от @blond |
"matcha": "0.6.0", | ||
"mocha": "2.2.5", | ||
"must": "0.12.0" | ||
"chai": "3.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Напоминаю, что зависимости лучше ставить через npm i chai -D
, чтобы порядок в package.json
был правильный.
После Написал немного замечаний. Становится сложно ревьювить из-за кол-ва кейсов: сложно понять каких кейсов не хватает. Давай начнём думать на какие разделы поделить кейсы. Можно оформить отдельными задачими. На каждый такой раздел свой отдельный PR. Начинать лучше с самых простой и очевидной группы кейсов. |
All tests from this PR were already merged in another PRs. |
Resolved #3
Added basic tests covering input params processing, dependency ordering and exceptions on retain cycles.