-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Themekit in browser #126
Themekit in browser #126
Conversation
} | ||
} | ||
|
||
to_ret.properties = deepExtend([{}, to_ret.properties, props]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Хм, а deepExtend
больше не нужен? Если да, то надо не забыть импорт удалить
let chalk = require('chalk') | ||
|
||
let fs | ||
if (typeof window === 'undefined') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Давай вообще все дефолтные экшены удалим, мы нигде их не использовали и не будем
chalk = require('chalk'); | ||
|
||
|
||
let fs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
А у тебя этот модуль где-то в браузере подключается?
chalk = require('chalk'); | ||
|
||
let fs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Тут тоже вопрос, подключается ли этот модуль в браузере?
chalk = require('chalk'), | ||
filterProperties = require('./filterProperties'), | ||
GroupMessages = require('./utils/groupMessages'); | ||
|
||
let fs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
и тут
@@ -41,8 +48,10 @@ export function createStyleDictionaryConfig({ sources, entry, platform, output } | |||
return acc | |||
}, {}) | |||
|
|||
// To work in browser we should pass `properties` and set `include` to [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Что-то не понимаю, почему так, почему нельзя возвращать только одно свойство?
fs
,require('.yaml')
иrequire(json5)
подключаются только в node среде