Themekit in browser #126
Merged
Themekit in browser #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axaxaman
reviewed
Jun 22, 2021
yarastqt
reviewed
Jun 23, 2021
| } | ||
| } | ||
|
|
||
| to_ret.properties = deepExtend([{}, to_ret.properties, props]); |
There was a problem hiding this comment.
Хм, а deepExtend больше не нужен? Если да, то надо не забыть импорт удалить
| let chalk = require('chalk') | ||
|
|
||
| let fs | ||
| if (typeof window === 'undefined') { |
There was a problem hiding this comment.
Давай вообще все дефолтные экшены удалим, мы нигде их не использовали и не будем
| chalk = require('chalk'); | ||
|
|
||
|
|
||
| let fs |
There was a problem hiding this comment.
А у тебя этот модуль где-то в браузере подключается?
| chalk = require('chalk'); | ||
|
|
||
| let fs |
There was a problem hiding this comment.
Тут тоже вопрос, подключается ли этот модуль в браузере?
| chalk = require('chalk'), | ||
| filterProperties = require('./filterProperties'), | ||
| GroupMessages = require('./utils/groupMessages'); | ||
|
|
||
| let fs |
| @@ -41,8 +48,10 @@ export function createStyleDictionaryConfig({ sources, entry, platform, output } | |||
| return acc | |||
| }, {}) | |||
|
|
|||
| // To work in browser we should pass `properties` and set `include` to [] | |||
There was a problem hiding this comment.
Что-то не понимаю, почему так, почему нельзя возвращать только одно свойство?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fs,require('.yaml')иrequire(json5)подключаются только в node среде