Skip to content

Commit

Permalink
Merge pull request #516 from bemusic/remove-old-stuffs
Browse files Browse the repository at this point in the history
Dependencies cleanup
  • Loading branch information
dtinth committed Dec 8, 2018
2 parents 3faa032 + 9b1ee60 commit 1ef5f57
Show file tree
Hide file tree
Showing 11 changed files with 46 additions and 661 deletions.
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
/dist/
*.mp3
/code-review-result.txt
package-lock.json

# created by git-ignore
Expand Down
28 changes: 0 additions & 28 deletions appveyor.yml

This file was deleted.

39 changes: 0 additions & 39 deletions bin/upload-code-review

This file was deleted.

15 changes: 0 additions & 15 deletions config/webpack.js
Original file line number Diff line number Diff line change
Expand Up @@ -227,16 +227,6 @@ function applyKarmaConfig(config) {
return config
}

function applyTestBedConfig(config) {
config.entry = './test/testBed.entry.js'
config.testBed = {
configureExpressApp: (app, express) => {
app.use('/src', express.static(path('src')))
},
}
return config
}

export const generateWebConfig = flowRight(
applyWebConfig,
generateBaseConfig
Expand All @@ -247,11 +237,6 @@ export const generateKarmaConfig = flowRight(
generateBaseConfig
)

export const generateTestBedConfig = flowRight(
applyTestBedConfig,
generateBaseConfig
)

export default generateWebConfig()

function CompileProgressPlugin() {
Expand Down
9 changes: 0 additions & 9 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,6 @@
"build:netlify": "./bin/netlify-build",
"pre-deploy": "gulp pre-deploy",
"codecov": "codecov",
"build:ios": "cross-env NODE_ENV=ios gulp build",
"ci:code-review": "npm run code-review; ./bin/upload-code-review",
"code-review": "gulp code-review",
"lint": "gulp lint",
"postbootstrap": "lerna run prepare",
"pre-commit": "gulp pre-commit",
Expand All @@ -32,8 +29,6 @@
"style:check": "yarn prettier --list-different './**/*.{js,jsx,ts,tsx,json,scss,css,yml}'",
"style:fix": "yarn prettier --write './**/*.{js,jsx,ts,tsx,json,scss,css,yml}'",
"test": "cross-env NODE_ENV=test BEMUSE_COV=true gulp test",
"test-bed": "cross-env NODE_ENV=test test-bed",
"travis": "gulp travis",
"readme:update": "markdown-toc -i README.md && prettier --write README.md"
},
"importSort": {
Expand Down Expand Up @@ -93,7 +88,6 @@
"gulp-gh-pages": "git://github.com/dtinth/gulp-gh-pages",
"gulp-mocha": "^6.0.0",
"gulp-util": "^3.0.8",
"hide-stack-frames-from": "^1.0.0",
"import-sort-style-renke": "^2.4.0",
"istanbul-instrumenter-loader": "^3.0.1",
"jade": "^1.9.2",
Expand All @@ -113,7 +107,6 @@
"minimatch": "^3.0.4",
"mocha": "^5.2.0",
"node-env": "^0.1.6",
"node-notifier": "^4.0.3",
"node-sass": "^4.9.3",
"nyc": "^11.9.0",
"pegjs": "^0.10.0",
Expand All @@ -123,7 +116,6 @@
"prettier": "^1.15.3",
"puppeteer": "^1.9.0",
"raw-loader": "^0.5.1",
"react-transform-catch-errors": "^1.0.1",
"rimraf": "^2.6.2",
"sass-loader": "^7.1.0",
"script-loader": "^0.7.2",
Expand Down Expand Up @@ -194,7 +186,6 @@
"reselect": "^2.5.1",
"rxjs": "^5.5.12",
"screenfull": "^3.3.3",
"test-bed": "^0.777.77-beta",
"throat": "^2.0.2",
"timesynchro": "^1.0.1",
"updeep": "^0.16.0",
Expand Down
72 changes: 36 additions & 36 deletions packages/bms/README.md
Original file line number Diff line number Diff line change
@@ -1,11 +1,9 @@

<h1 align="center">bms-js</h1>

<h3 align="center">BMS Parser for JavaScript</h3>

<p align="center">
<a href="https://waffle.io/bemusic/bemuse?source=bemusic%2Fbms-js"><img src="http://img.shields.io/badge/wow%20much-waffle-green.svg?style=flat" alt="Waffles"></a>
<a href="https://travis-ci.org/bemusic/bms-js"><img src="https://img.shields.io/travis/bemusic/bms-js.svg?style=flat" alt="Travis CI"></a>
<a href="https://codeclimate.com/github/bemusic/bms-js"><img src="https://img.shields.io/codeclimate/github/bemusic/bms-js.svg?style=flat" alt="Code Climate"></a>
<a href="https://coveralls.io/r/bemusic/bms-js"><img src="https://img.shields.io/coveralls/bemusic/bms-js.svg?style=flat" alt="Coveralls"></a>
<a href="https://david-dm.org/bemusic/bms-js" title="Dependency status"><img src="https://david-dm.org/bemusic/bms-js.svg" alt="david-dm Dependency Status"></a>
Expand All @@ -14,47 +12,49 @@

---

A [Be-Music Source](http://en.wikipedia.org/wiki/Be-Music_Source) file-format parser.
It is made primarily for usage in [Bemuse](https://github.com/bemusic/bemuse).


Usage
-----
A [Be-Music Source](http://en.wikipedia.org/wiki/Be-Music_Source) file-format
parser. It is made primarily for usage in
[Bemuse](https://github.com/bemusic/bemuse).

Documentation has been lacking. For now, please see [issue 26](https://github.com/bemusic/bms-js/issues/26) for preliminary usage notes.
## Usage

Documentation has been lacking. For now, please see
[issue 26](https://github.com/bemusic/bms-js/issues/26) for preliminary usage
notes.

BMS Parsing Stages
------------------
## BMS Parsing Stages

BMS will be parsed in three stages:

1. Use `bms.Reader` to turn a Buffer with BMS file content into a String.
- Performs [character set detection](http://hitkey.nekokan.dyndns.info/cmds.htm#CHARSET). Since BMS file encoding varies.
- This part is done by bemusepack to convert BMS file into UTF-8.
- Performs
[character set detection](http://hitkey.nekokan.dyndns.info/cmds.htm#CHARSET).
Since BMS file encoding varies.
- This part is done by bemusepack to convert BMS file into UTF-8.
2. Use `bms.Compiler` to compile the String into a `BMSChart`.
- Syntax-level processing is done here, such as:
- \#RANDOM
- \#SETRANDOM
- \#SWITCH
- Results in three primary data structures:
- `headers` contains all BMS headers
- `objects` contains all BMS objects on the timeline.
- `timeSignature` contains the time signature information.
- also allows converting from measure+fraction to beat
3. `BMSChart` contains all information needed to further process the song. These modules can then be used to extract information from `BMSChart`.
- `SongInfo` allows looking up title, subtitle, artist, maker, and genre.
- Implicit/multiplex subtitles taken into account here.
- `Timing` allows conversion from beat to seconds.
- BPM, BPM changes, STOP objects, and STP commands taken into account here.
- `Positioning` allows conversion from beat to in-game position.
- [SPEED and SCROLL commands (BEMUSE's BMS extensions)](http://bemusic.viewdocs.io/bemuse/BMS_EXTENSION.md) taken into account here.
- `Notes` parses the notechart, resulting in in-game notes.
- Channel mapping is taken into consideration here.
- Normal notes and long notes taken into account here.
- Also emits list of notes to autoplay.

Other Utility Classes
---------------------
- Syntax-level processing is done here, such as:
- \#RANDOM
- \#SETRANDOM
- \#SWITCH
- Results in three primary data structures:
- `headers` contains all BMS headers
- `objects` contains all BMS objects on the timeline.
- `timeSignature` contains the time signature information.
- also allows converting from measure+fraction to beat
3. `BMSChart` contains all information needed to further process the song. These
modules can then be used to extract information from `BMSChart`.
- `SongInfo` allows looking up title, subtitle, artist, maker, and genre.
- Implicit/multiplex subtitles taken into account here.
- `Timing` allows conversion from beat to seconds.
- BPM, BPM changes, STOP objects, and STP commands taken into account here.
- `Positioning` allows conversion from beat to in-game position.
- [SPEED and SCROLL commands (BEMUSE's BMS extensions)](http://bemusic.viewdocs.io/bemuse/BMS_EXTENSION.md)
taken into account here.
- `Notes` parses the notechart, resulting in in-game notes.
- Channel mapping is taken into consideration here.
- Normal notes and long notes taken into account here.
- Also emits list of notes to autoplay.

## Other Utility Classes

- `Speedcore` allows calculation of position and velocity over a linear graph.
1 change: 0 additions & 1 deletion src/app/ui/AboutScene.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,6 @@ class AboutScene extends React.Component {
repository.
</li>
<li>
<a href='https://travis-ci.org/'>Travis CI</a> and{' '}
<a href='https://circleci.com/'>CircleCI</a> continuously runs
our automated tests and notifies us when our new code breaks
existing features. CircleCI also builds and deploys new version
Expand Down
12 changes: 0 additions & 12 deletions src/test/testBed.entry.js

This file was deleted.

109 changes: 0 additions & 109 deletions tasks/code-review.js

This file was deleted.

3 changes: 0 additions & 3 deletions webpack.config.test-bed.js

This file was deleted.

0 comments on commit 1ef5f57

Please sign in to comment.