Skip to content

Commit

Permalink
Update TODO references: #576, #577, #578, #579, #580, #581, #582, #583,
Browse files Browse the repository at this point in the history
  • Loading branch information
todo-actions[bot] committed Oct 2, 2019
1 parent a5808e8 commit ff90d37
Show file tree
Hide file tree
Showing 17 changed files with 63 additions and 63 deletions.
90 changes: 45 additions & 45 deletions .yarn/releases/yarn-1.17.3.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion packages/bemuse-tools/src/audio.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export class AudioConvertor {
_doConvert(path, type) {
return this._SoX(path, type)
}
// TODO [$5d94c82086dc190007494e7b]: Convert the `_SoX` method to async function (instead of using `co`) in [bemuse-tools] src/audio.js
// TODO [#621]: Convert the `_SoX` method to async function (instead of using `co`) in [bemuse-tools] src/audio.js
// See issue #575 for more details.
_SoX(path, type) {
return co(
Expand Down
2 changes: 1 addition & 1 deletion packages/bemuse-tools/src/bemuse-packer.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export class BemusePacker {
this._refs.push(ref)
return ref
}
// TODO [$5d94c82086dc190007494e7c]: Convert the `write` method to async function (instead of using `co`) in [bemuse-tools] src/bemuse-packer.js
// TODO [#622]: Convert the `write` method to async function (instead of using `co`) in [bemuse-tools] src/bemuse-packer.js
// See issue #575 for more details.
write(folder) {
return co(
Expand Down
2 changes: 1 addition & 1 deletion packages/bemuse-tools/src/indexer.js
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ function Cache(path) {
}
}

// TODO [$5d94c82086dc190007494e7d]: Convert usage of `co` to async function in [bemuse-tools] src/indexer.js
// TODO [#623]: Convert usage of `co` to async function in [bemuse-tools] src/indexer.js
// See issue #575 for more details.
export function index(path, { recursive }) {
return co(function*() {
Expand Down
2 changes: 1 addition & 1 deletion packages/bemuse-tools/src/packer.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import BemusePacker from './bemuse-packer'
let mkdirp = Promise.promisify(require('mkdirp'))
let fileStat = Promise.promisify(fs.stat, fs)

// TODO [$5d94c82086dc190007494e7e]: Convert the `packIntoBemuse` function to async function (instead of using `co`) in [bemuse-tools] src/packer.js
// TODO [#624]: Convert the `packIntoBemuse` function to async function (instead of using `co`) in [bemuse-tools] src/packer.js
// See issue #575 for more details.
export function packIntoBemuse(path) {
return co(function*() {
Expand Down
2 changes: 1 addition & 1 deletion src/app/game-launcher.ts
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ export async function launch({
invariant(options, 'Options must be passed!')

// initialize the loading specification
// TODO [$5d94c82086dc190007494e7f]: Create the LoadSpec object at the end instead of building object from blank.
// TODO [#625]: Create the LoadSpec object at the end instead of building object from blank.
let loadSpec: LoadSpec = {} as any
loadSpec.songId = song.id

Expand Down
2 changes: 1 addition & 1 deletion src/auto-synchro/music/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ let ASSET_URLS = {
* Loads the files and create a music instance.
*/
export function load() {
// TODO [$5d94c82086dc190007494e80]: Convert the `load` function to async function (instead of using `co`) in src/auto-synchro/music.js
// TODO [#626]: Convert the `load` function to async function (instead of using `co`) in src/auto-synchro/music.js
// See issue #575 for more details.
return co(function*() {
let master = new SamplingMaster(context)
Expand Down
2 changes: 1 addition & 1 deletion src/coming-soon/demo/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export function main(element) {
}
}

// TODO [$5d94c82086dc190007494e81]: Convert the `go` function to async function (instead of using `co`) in src/coming-soon/demo/index.js
// TODO [#627]: Convert the `go` function to async function (instead of using `co`) in src/coming-soon/demo/index.js
// See issue #575 for more details.
function go(loader, element) {
let master = new SamplingMaster(ctx)
Expand Down
2 changes: 1 addition & 1 deletion src/devtools/playgrounds/skin.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import MAIN from 'bemuse/utils/main-element'
import co from 'co'
import { fromBMSChart } from 'bemuse-notechart/lib/loader/BMSNotechartLoader'

// TODO [$5d94c82086dc190007494e82]: Convert the `main` method to async function (instead of using `co`) in src/devtools/playgrounds/skin.js
// TODO [#628]: Convert the `main` method to async function (instead of using `co`) in src/devtools/playgrounds/skin.js
// See issue #575 for more details.
export function main() {
co(function*() {
Expand Down
2 changes: 1 addition & 1 deletion src/game/display/player-display.js
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ export class PlayerDisplay {

export default PlayerDisplay

// TODO [$5d94c82086dc190007494e83]: MOVE THIS (getKeyMode) TO bemuse-notechart
// TODO [#629]: MOVE THIS (getKeyMode) TO bemuse-notechart
//
function getKeyMode(notechart, scratch) {
const usedColumns = {}
Expand Down
4 changes: 2 additions & 2 deletions src/game/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ export function main() {
})
}

// TODO [$5d94c82086dc190007494e84]: Convert the `getSong` function to async function (instead of using `co.wrap`) in src/game/index.js
// TODO [#630]: Convert the `getSong` function to async function (instead of using `co.wrap`) in src/game/index.js
// See issue #575 for more details.
let getSong = co.wrap(function*() {
let kbm = (query.keyboard || '').split(',').map(x => +x)
Expand Down Expand Up @@ -82,7 +82,7 @@ export function main() {
return loadSpec
})

// TODO [$5d94c82086dc190007494e85]: Convert the `co` invocation to async function IIFE in src/game/index.js
// TODO [#631]: Convert the `co` invocation to async function IIFE in src/game/index.js
co(function*() {
let loadSpec = yield getSong()
let { tasks, promise } = GameLoader.load(loadSpec)
Expand Down
4 changes: 2 additions & 2 deletions src/online/scoreboard-system/createScoreboardClient.js
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ export default function createScoreboardClient({
invariant(typeof username === 'string', 'username must be a string')
invariant(typeof password === 'string', 'password must be a string')
invariant(typeof email === 'string', 'email must be a string')
// TODO [$5d94c82086dc190007494e86]: Convert the `signUp` method to async function (instead of using `co`) in src/online/scoreboard-system/createScoreboardClient.js
// TODO [#632]: Convert the `signUp` method to async function (instead of using `co`) in src/online/scoreboard-system/createScoreboardClient.js
// See issue #575 for more details.
return co(function*() {
const { idToken } = yield* authenticationFlow.signUp(
Expand All @@ -235,7 +235,7 @@ export default function createScoreboardClient({
loginByUsernamePassword({ username, password }) {
invariant(typeof username === 'string', 'username must be a string')
invariant(typeof password === 'string', 'password must be a string')
// TODO [$5d94c82086dc190007494e87]: Convert the `loginByUsernamePassword` method to async function (instead of using `co`) in src/online/scoreboard-system/createScoreboardClient.js
// TODO [#633]: Convert the `loginByUsernamePassword` method to async function (instead of using `co`) in src/online/scoreboard-system/createScoreboardClient.js
return co(function*() {
const { idToken } = yield* authenticationFlow.loginByUsernamePassword(
username,
Expand Down
2 changes: 1 addition & 1 deletion src/resources/dnd-resources.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import {
downloadFileEntryFromURL,
} from './custom-song-resources'

// TODO [$5d94c82086dc190007494e88]: Remove the `DndResources` class and have users of this class create a `CustomSongResources` directly.
// TODO [#634]: Remove the `DndResources` class and have users of this class create a `CustomSongResources` directly.
//
// The original implementation of DndResources class has been extracted
// into a CustomSongResources superclass in commit cc6a6e70586487ef476890f5a7911837186a7a32,
Expand Down
2 changes: 1 addition & 1 deletion src/scene-manager/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ export class SceneManager {
})
}

// TODO [$5d94c82086dc190007494e89]: Convert the `_transitionTo` method to async function (instead of using `co`) in src/scene-manager/index.js
// TODO [#635]: Convert the `_transitionTo` method to async function (instead of using `co`) in src/scene-manager/index.js
// See issue #575 for more details.
_transitionTo(getNextScene) {
return co(
Expand Down
2 changes: 1 addition & 1 deletion src/scintillator/index.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ describe('Scintillator', function() {
describe('#load', function() {
it(
'should load skin and return skin node',
// TODO [$5d94c82086dc190007494e8a]: Convert all `co.wrap()` calls in src/scintillator/index.spec.js to async functions
// TODO [#636]: Convert all `co.wrap()` calls in src/scintillator/index.spec.js to async functions
// See issue #575 for more details.
co.wrap(function*() {
let skin = yield Scintillator.load(fixture('bare.xml'))
Expand Down
2 changes: 1 addition & 1 deletion src/scintillator/loader.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import Resources from './resources'

const log = debug('scintillator:loader')

// TODO [$5d94c82086dc190007494e8b]: Convert the `load` function to async function (instead of using `co`) in src/scintillator/loader.js
// TODO [#637]: Convert the `load` function to async function (instead of using `co`) in src/scintillator/loader.js
// See issue #575 for more details.
export function load(xmlPath, progress) {
return co(function*() {
Expand Down
2 changes: 1 addition & 1 deletion tasks/pre-deploy.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ const readFile = Promise.promisify(fs.readFile, fs)

gulp.task(
'pre-deploy',
// TODO [$5d94c82086dc190007494e8c]: Convert the `co.wrap()` call in tasks/pre-deploy.js to async function
// TODO [#638]: Convert the `co.wrap()` call in tasks/pre-deploy.js to async function
// See issue #575 for more details.
co.wrap(function*() {
let data = yield readFile(path('dist', 'index.html'), 'utf-8')
Expand Down

0 comments on commit ff90d37

Please sign in to comment.