Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Deps upgrade - v42 edition #498

Merged
merged 9 commits into from
Oct 14, 2018
Merged

⬆️ Deps upgrade - v42 edition #498

merged 9 commits into from
Oct 14, 2018

Conversation

resir014
Copy link
Member

@resir014 resir014 commented Oct 1, 2018

Some more upgrades for our dependencies + devDependencies.

@codecov-io
Copy link

codecov-io commented Oct 1, 2018

Codecov Report

Merging #498 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #498   +/-   ##
======================================
  Coverage    84.1%   84.1%           
======================================
  Files         171     171           
  Lines        5387    5387           
  Branches        1       1           
======================================
  Hits         4531    4531           
  Misses        856     856
Impacted Files Coverage Δ
src/test/prepareTestEnvironment.js 100% <ø> (ø) ⬆️
src/utils/download.spec.js 100% <100%> (ø) ⬆️
src/utils/read-blob.spec.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9307caa...d2a99a9. Read the comment docs.

@resir014 resir014 mentioned this pull request Oct 8, 2018
@resir014 resir014 changed the title [WIP] ⬆️ Deps upgrade - v42 edition ⬆️ Deps upgrade - v42 edition Oct 11, 2018
@dtinth
Copy link
Member

dtinth commented Oct 14, 2018

I am fixing the merge conflicts.

@resir014
Copy link
Member Author

Cool. It might be also safe to rebuild the yarn.lock on the PR too.

@dtinth
Copy link
Member

dtinth commented Oct 14, 2018

@resir014 You mean, rebuild yarn.lock from scratch?

@resir014
Copy link
Member Author

Actually nevermind. I just realised it's been done on the other PR 😅

@dtinth
Copy link
Member

dtinth commented Oct 14, 2018

I am having trouble with the internet connection right now (yarn install won’t finish and stuck at building puppeteer), so I reverted yarn.lock to current master for now.

That means before merging, we have to run yarn.lock (either rebuild from scratch or using the master version) to update it.

@resir014
Copy link
Member Author

resir014 commented Oct 14, 2018 via email

@dtinth
Copy link
Member

dtinth commented Oct 14, 2018

Thanks! I think we can merge this now.

  • After Babel 7 is added, somehow, Danger stops working because it tries to use Babel 6 to transpile ES6 code. Our Babel config references plugins that only works with Babel 7, thus crashing Danger. Upgrading to latest Danger fixes it.

  • Seems like Prettier now uses - instead of * for list items, so that’s why the README file has to be updated too.

@dtinth dtinth merged commit 6941f7f into master Oct 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants