Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mute music preview during calibration #507

Merged
merged 2 commits into from
Oct 18, 2018
Merged

Mute music preview during calibration #507

merged 2 commits into from
Oct 18, 2018

Conversation

jkemperman
Copy link
Contributor

Uses message events to inform the main window when calibration has started, and when the calibration window closes. Actual pausing/resuming is handled by the MusicSelectPreviewer component.

Fixes #449

@codecov-io
Copy link

codecov-io commented Oct 17, 2018

Codecov Report

Merging #507 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #507   +/-   ##
======================================
  Coverage    84.1%   84.1%           
======================================
  Files         171     171           
  Lines        5387    5387           
  Branches        1       1           
======================================
  Hits         4531    4531           
  Misses        856     856

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d1ecd2...2d66e4f. Read the comment docs.

Copy link
Member

@dtinth dtinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution!

Merging this now :)

@dtinth dtinth merged commit 8145b4e into bemusic:master Oct 18, 2018
@jkemperman jkemperman deleted the mute-during-calibration branch October 18, 2018 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Latency calibration should mute menu music while open
3 participants