Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert stuff to TypeScript #544

Merged
merged 11 commits into from
Aug 30, 2019
Merged

Convert stuff to TypeScript #544

merged 11 commits into from
Aug 30, 2019

Conversation

dtinth
Copy link
Member

@dtinth dtinth commented Aug 29, 2019

Changelog

Several core objects have been converted to TypeScript to make the game code easier to maintain. This includes Judgments, Game, Player, GameInput, GameState, PlayerState and PlayerStats in the game, and Callbacks, Observable and Progress in the utilities.

@codecov-io
Copy link

codecov-io commented Aug 29, 2019

Codecov Report

Merging #544 into master will decrease coverage by 0.37%.
The diff coverage is 94.37%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #544      +/-   ##
==========================================
- Coverage   81.31%   80.93%   -0.38%     
==========================================
  Files         156      156              
  Lines        4682     4706      +24     
  Branches       77      162      +85     
==========================================
+ Hits         3807     3809       +2     
- Misses        853      857       +4     
- Partials       22       40      +18
Impacted Files Coverage Δ
src/progress/index.ts 100% <100%> (ø)
src/game/input/control.ts 100% <100%> (ø)
src/utils/observable.ts 100% <100%> (ø)
src/game/input/index.ts 82.35% <100%> (ø)
src/game/player.ts 100% <100%> (ø)
src/game/judgments.ts 96.49% <100%> (ø)
src/game/state/player-state.spec.js 100% <100%> (ø) ⬆️
src/utils/callbacks.ts 76.92% <76.92%> (ø)
src/game/state/player-state.ts 83.76% <90.74%> (ø)
src/game/state/player-stats.ts 91.78% <94.11%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e287f9...43e8777. Read the comment docs.

release-train bot added a commit that referenced this pull request Aug 30, 2019
@dtinth dtinth merged commit 43e8777 into master Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants