Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress freestyle sound when performing a glissando in 3d mode #546

Merged
merged 1 commit into from
Aug 31, 2019

Conversation

dtinth
Copy link
Member

@dtinth dtinth commented Aug 30, 2019

Changelog

When playing in 3D mode (e.g. using a touch screen), performing a fast glissando between 2 notes with one column of gap in-between will no longer emit the sound of the gap. For example, given a note pattern 1-3-5-7, you can swipe your finger from 1~7, and the game will suppress the sounds of column 2-4-6. This improves the playing experience in mobile devices.

@dtinth dtinth added the c:ready label Aug 30, 2019
@codecov-io
Copy link

codecov-io commented Aug 30, 2019

Codecov Report

Merging #546 into master will increase coverage by 0.02%.
The diff coverage is 89.13%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #546      +/-   ##
==========================================
+ Coverage   80.93%   80.95%   +0.02%     
==========================================
  Files         156      156              
  Lines        4706     4732      +26     
  Branches      162      166       +4     
==========================================
+ Hits         3809     3831      +22     
- Misses        857      859       +2     
- Partials       40       42       +2
Impacted Files Coverage Δ
src/game/state/player-state.spec.js 100% <100%> (ø) ⬆️
src/game/state/player-state.ts 82.31% <75%> (-1.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 840209b...8681c53. Read the comment docs.

release-train bot added a commit that referenced this pull request Aug 31, 2019
@dtinth dtinth merged commit 8681c53 into master Aug 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants