Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support zip loading #547

Merged
merged 3 commits into from
Aug 31, 2019
Merged

Support zip loading #547

merged 3 commits into from
Aug 31, 2019

Conversation

dtinth
Copy link
Member

@dtinth dtinth commented Aug 31, 2019

Changelog

Bemuse can now load custom songs directly from .zip, .rar and .7z files. You can now drop an archive file into Bemuse. This is possible thanks to libarchive.js which is a port of libarchive to WebAssembly.

@akibot
Copy link
Contributor

akibot commented Aug 31, 2019

Warnings
⚠️ Please include a description of your PR changes.

Generated by 🚫 dangerJS

@codecov-io
Copy link

codecov-io commented Aug 31, 2019

Codecov Report

Merging #547 into master will decrease coverage by 0.03%.
The diff coverage is 89.6%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #547      +/-   ##
=========================================
- Coverage   80.93%   80.9%   -0.04%     
=========================================
  Files         156     156              
  Lines        4706    4729      +23     
  Branches      162     177      +15     
=========================================
+ Hits         3809    3826      +17     
- Misses        857     859       +2     
- Partials       40      44       +4
Impacted Files Coverage Δ
src/app/song-loader/index.js 87.09% <ø> (+0.43%) ⬆️
src/progress/index.spec.js 100% <ø> (ø) ⬆️
src/progress/utils.spec.js 100% <ø> (ø) ⬆️
src/progress/formatters.spec.js 100% <ø> (ø) ⬆️
src/resources/bemuse-package.ts 100% <100%> (ø)
src/progress/Progress.ts 100% <100%> (ø)
src/resources/url.ts 72.72% <66.66%> (ø)
src/progress/utils.ts 72.22% <72.22%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 840209b...d848874. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants