Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More TypeScript #549

Merged
merged 14 commits into from
Sep 2, 2019
Merged

More TypeScript #549

merged 14 commits into from
Sep 2, 2019

Conversation

dtinth
Copy link
Member

@dtinth dtinth commented Sep 2, 2019

Changelog

Upgraded TypeScript to latest version, 3.6.2, and converted some more code that deals with game initialization logic to TypeScript.

@codecov-io
Copy link

codecov-io commented Sep 2, 2019

Codecov Report

Merging #549 into master will decrease coverage by 0.06%.
The diff coverage is 95.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #549      +/-   ##
==========================================
- Coverage   80.92%   80.86%   -0.07%     
==========================================
  Files         156      156              
  Lines        4755     4760       +5     
  Branches      181      184       +3     
==========================================
+ Hits         3848     3849       +1     
- Misses        861      862       +1     
- Partials       46       49       +3
Impacted Files Coverage Δ
src/game/player.ts 100% <100%> (ø) ⬆️
src/game/state/player-state.ts 82.82% <100%> (+0.5%) ⬆️
src/app/interactors/createAutoVelocity.ts 100% <100%> (ø)
src/logger/index.ts 66.66% <50%> (ø)
src/sampling-master/ogg.spec.ts 83.33% <0%> (-7.58%) ⬇️
src/resources/url.ts 66.66% <0%> (-6.07%) ⬇️
src/sampling-master/ogg.ts 79.16% <0%> (-1.69%) ⬇️
src/resources/bemuse-package.ts 98.43% <0%> (-1.57%) ⬇️
src/online/scoreboard-system/OnlineService.js 1.51% <0%> (-0.03%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17dbf15...d1ffd9d. Read the comment docs.

@dtinth dtinth added the c:ready label Sep 2, 2019
release-train bot added a commit that referenced this pull request Sep 2, 2019
@dtinth dtinth merged commit d1ffd9d into master Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants