Updates usage of co to async function in [bemuse-tools] src/indexer.js
#640
Conversation
Codecov Report
@@ Coverage Diff @@
## master #640 +/- ##
==========================================
- Coverage 81.07% 80.85% -0.22%
==========================================
Files 156 156
Lines 4776 4764 -12
Branches 184 184
==========================================
- Hits 3872 3852 -20
- Misses 855 863 +8
Partials 49 49
Continue to review full report at Codecov.
|
packages/bemuse-tools/src/indexer.js
Outdated
| let glob = Promise.promisify(require('glob')) | ||
| let fileStat = util.promisify(fs.stat, fs) | ||
| let readFile = util.promisify(fs.readFile, fs) | ||
| let writeFile = util.promisify(fs.writeFile, fs) |
There was a problem hiding this comment.
Thanks for also removing Bluebird. However, util.promisify only takes one argument. Can you help fix this?
There was a problem hiding this comment.
Should I update all references to Bluebird to use native Promise and the promisify function from util like I did here?
There was a problem hiding this comment.
I agree... I would like to move away from using Bluebird instance methods. I'd prefer it in a separate PR though to make it easy for me to review and test...
Do you plan to update the whole project?
There was a problem hiding this comment.
Sure, why not. Let me create a new PR without Bluebird.
|
Kudos, SonarCloud Quality Gate passed!
|
Fixes #623