Updates usage of co to async function in createScoreboardClient
#644
Conversation
Codecov Report
@@ Coverage Diff @@
## master #644 +/- ##
==========================================
- Coverage 81.07% 80.62% -0.45%
==========================================
Files 156 156
Lines 4776 4780 +4
Branches 184 184
==========================================
- Hits 3872 3854 -18
- Misses 855 877 +22
Partials 49 49
Continue to review full report at Codecov.
|
| // TODO [#632]: Convert the `signUp` method to async function (instead of using `co`) in src/online/scoreboard-system/createScoreboardClient.js | ||
| // See issue #575 for more details. | ||
| return co(function*() { | ||
| const { idToken } = yield* authenticationFlow.signUp( |
There was a problem hiding this comment.
This one is a bit tricky because we’re using yield* instead of yield. Simply changing it to await doesn't work as we will get back an iterator instead of a Promise. To really fix this you have to convert generator functions in authenticationFlow to async functions. Would you help do that for me?
| invariant(typeof username === 'string', 'username must be a string') | ||
| invariant(typeof password === 'string', 'password must be a string') | ||
| // TODO [#633]: Convert the `loginByUsernamePassword` method to async function (instead of using `co`) in src/online/scoreboard-system/createScoreboardClient.js | ||
| return co(function*() { | ||
| const { idToken } = yield* authenticationFlow.loginByUsernamePassword( |
|
Kudos, SonarCloud Quality Gate passed!
|
fixes #632 and #633