Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from Lerna+Yarn to Rush+pnpm #730

Merged
merged 32 commits into from
Oct 29, 2021
Merged

Switch from Lerna+Yarn to Rush+pnpm #730

merged 32 commits into from
Oct 29, 2021

Conversation

dtinth
Copy link
Member

@dtinth dtinth commented Oct 28, 2021 •
edited

If the experiment is successful, make sure to:

  • Update docs
  • Make sure Netlify can build
  • Make sure it works on Windows
  • Make sure it works on GitPod
  • Make sure cmd+shift+b is working in VSCode

Changelog

Changed the monorepo manager from Yarn+Lerna to Rush+pnpm.

@dtinth
Adding Rush
c04e368
@dtinth
Add Prettier autoinstaller
5eae95a
@dtinth
Rename to bemuse-linter
ae6d7fb
@dtinth
Add lint command
9466c70
@dtinth
Change "prepare" script to "build"
f4edd10
@dtinth
Make sure all subprojects are building properly (except bemuse)
aa408a4
@dtinth
Make bemuse buildable in Rush
565d33c
@dtinth
Make website project buildable
0498b7c
@dtinth
Remove Yarn and root package json
8ae769a
@dtinth
Make Danger run
6811d9f
@dtinth
Fix testing
e51ebbb
@dtinth
Allow test warnings
89491ee
@dtinth
To typecheck dependencies would have to be built
9c12ffd
@dtinth
Fix native promise not having Bluebird methods
334cae3
@dtinth
Fix lint
bb93d3c
@dtinth
Fix build script
0d602c4
@dtinth
Add e2e
ea59b40
@dtinth
Apparently rush install doesn’t support filtering
dec70e6
@dtinth
Upgrade Node version
895f30c
@dtinth
Use available Node image
2a6ef34
@dtinth
Use node common/scripts/install-run-rush.js instead of rush
47baf52
@dtinth
Fix type errors
b2231e3
@dtinth
Silence warnings in build scripts for now
102293e 
microsoft/rushstack#1329
@dtinth
Update Gitpod and VSCode config
970f941
@dtinth dtinth marked this pull request as ready for review October 29, 2021 18:13
@sonarcloud
Copy link

sonarcloud bot commented Oct 29, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dtinth dtinth changed the title Experiment with Rush (again) Switch from Lerna+Yarn to Rush+pnpm Oct 29, 2021
release-train bot added a commit that referenced this pull request Oct 29, 2021
@release-train
Merge pull request #730 from dtinth/rushv2
aa8e7f4
release-train bot added a commit that referenced this pull request Oct 29, 2021
@release-train
Merge pull request #730 from dtinth/rushv2
c053dff
@release-train release-train bot mentioned this pull request Oct 29, 2021
Merged
@dtinth dtinth merged commit 06affb3 into master Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c:ready category:Internals
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@dtinth