Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove song folders #734

Merged
merged 5 commits into from
Oct 30, 2021
Merged

Remove song folders #734

merged 5 commits into from
Oct 30, 2021

Conversation

fResult
Copy link
Contributor

@fResult fResult commented Oct 30, 2021 •
edited by dtinth

Changelog

Detect song folder removals when rescanning the custom songs folder.

dtinth
dtinth requested changes Oct 30, 2021
View reviewed changes
Copy link
Member

@dtinth dtinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much, almost there — I have 1 change to request.

bemuse/src/custom-folder/index.ts Outdated Show resolved Hide resolved
fResult and others added 2 commits October 30, 2021 20:40
@fResult @dtinth
improve code
9ab0471 
initial `remainingSongs` with `state.songs || []`

Co-authored-by: Thai Pangsakulyanont <dtinth@spacet.me>
@fResult
initial state.songs
731394a
@sonarcloud
Copy link

sonarcloud bot commented Oct 30, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

dtinth
dtinth approved these changes Oct 30, 2021
View reviewed changes
Copy link
Member

@dtinth dtinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are passing now. (Don’t worry about the failing lint task; it’s a known issue.)

@dtinth
Copy link
Member

dtinth commented Oct 30, 2021

Thank you krubbbb!!!

@release-train release-train bot mentioned this pull request Oct 30, 2021
Merged
@dtinth dtinth merged commit 574c01a into bemusic:master Oct 30, 2021
@fResult fResult deleted the feature/songs/remove branch October 30, 2021 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtinth dtinth dtinth approved these changes

Assignees
No one assigned
Labels
c:ready category:Internals
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fResult @dtinth