Implement HD-BGA support for BMS files #745
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #744
Changelog
HD-BGA support for BMS files. Bemuse now tries to load BGAs in BMS files when an
.mp4
and.webm
files are provided.In prior versions, Bemuse did not support background animation (BGA) video for the BMS format, because most BMS archives at that time comes with low-resolution (256x256) video files. These files commonly use the MPG, AVI, or WMV format, which cannot be played on the web.
In 2016, the bmson project introduced recommendations for high-definition BGAs in bmson files. The specification recommended BGA files to be in MP4 or WebM format. These formats can be played on the web and it is supported natively in Bemuse. So since 2016, Bemuse supports BGA for bmson, but not BMS.
In 2018, beatoraja introduced support for high-definition BGAs in BMS files. BMS authors can put
bga.mp4
andbga.mpg
files side-by-side andbga.mp4
file will take precedence overbga.mpg
even ifbga.mpg
is specified in the BMS file (for backwards-compatibility with LR2).In 2021, it is now more common for BMS authors to distribute BMS archives with BGA files in both
.mp4
and.mpg
format. Therefore, Bemuse now follows this behavior by beatoraja.