Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement HD-BGA support for BMS files #745

Merged
merged 6 commits into from
Dec 20, 2021
Merged

Implement HD-BGA support for BMS files #745

merged 6 commits into from
Dec 20, 2021

Conversation

dtinth
Copy link
Member

@dtinth dtinth commented Dec 20, 2021

Closes #744

Changelog

HD-BGA support for BMS files. Bemuse now tries to load BGAs in BMS files when an .mp4 and .webm files are provided.

bga-support

In prior versions, Bemuse did not support background animation (BGA) video for the BMS format, because most BMS archives at that time comes with low-resolution (256x256) video files. These files commonly use the MPG, AVI, or WMV format, which cannot be played on the web.

In 2016, the bmson project introduced recommendations for high-definition BGAs in bmson files. The specification recommended BGA files to be in MP4 or WebM format. These formats can be played on the web and it is supported natively in Bemuse. So since 2016, Bemuse supports BGA for bmson, but not BMS.

In 2018, beatoraja introduced support for high-definition BGAs in BMS files. BMS authors can put bga.mp4 and bga.mpg files side-by-side and bga.mp4 file will take precedence over bga.mpg even if bga.mpg is specified in the BMS file (for backwards-compatibility with LR2).

In 2021, it is now more common for BMS authors to distribute BMS archives with BGA files in both .mp4 and .mpg format. Therefore, Bemuse now follows this behavior by beatoraja.

@sonarcloud
Copy link

sonarcloud bot commented Dec 20, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dtinth dtinth merged commit d45e710 into master Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support beatoraja HD-BGA convention for BMS files
1 participant