Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problem where sign-in is broken #776

Merged
merged 1 commit into from
Oct 23, 2022
Merged

Conversation

dtinth
Copy link
Member

@dtinth dtinth commented Oct 23, 2022

image

A regression is introduced in #772, this PR fixes it.

Changelog

Fixed a regression where the sign in and sign up function doesn’t work.

@sonarcloud
Copy link

sonarcloud bot commented Oct 23, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2022

Codecov Report

Base: 81.05% // Head: 81.05% // No change to project coverage 👍

Coverage data is based on head (8aece5f) compared to base (945f536).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #776   +/-   ##
=======================================
  Coverage   81.05%   81.05%           
=======================================
  Files         178      178           
  Lines        5290     5290           
  Branches      242      242           
=======================================
  Hits         4288     4288           
  Misses        931      931           
  Partials       71       71           
Impacted Files Coverage Δ
...online/scoreboard-system/createScoreboardClient.js 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dtinth dtinth merged commit 75b840d into master Oct 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants