Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to new scoreboard #785

Merged
merged 19 commits into from
Nov 28, 2022
Merged

Migrate to new scoreboard #785

merged 19 commits into from
Nov 28, 2022

Conversation

dtinth
Copy link
Member

@dtinth dtinth commented Nov 6, 2022

Changelog

Bemuse Online Ranking is back. The online ranking backend has been revamped with a more modern tech stack. We also migrated to another authentication provider (Firebase). Unfortunately, all passwords has been reset. Please reset your password by specifying a blank password when logging in.

@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2022

Codecov Report

Base: 81.74% // Head: 88.32% // Increases project coverage by +6.58% 🎉

Coverage data is based on head (0d1b374) compared to base (9f7a0b3).
Patch coverage: 64.28% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #785      +/-   ##
==========================================
+ Coverage   81.74%   88.32%   +6.58%     
==========================================
  Files         175      175              
  Lines        5307     5293      -14     
  Branches      248      269      +21     
==========================================
+ Hits         4338     4675     +337     
+ Misses        936      583     -353     
- Partials       33       35       +2     
Impacted Files Coverage Δ
...ne/scoreboard-system/createNextScoreboardClient.ts 0.00% <0.00%> (ø)
...ne/scoreboard-system/createFakeScoreboardClient.ts 80.00% <80.00%> (ø)
bemuse/src/online/index.spec.js 99.44% <100.00%> (+95.41%) ⬆️
...muse/src/online/scoreboard-system/OnlineService.js 80.35% <100.00%> (+80.35%) ⬆️
.../scoreboard-system/createLegacyScoreboardClient.ts
...src/online/scoreboard-system/authenticationFlow.js
bemuse/src/devtools/BemuseTestMode.js 16.66% <0.00%> (+5.55%) ⬆️
bemuse/src/online/data-store.js 87.50% <0.00%> (+6.25%) ⬆️
bemuse/src/online/operations.js 88.88% <0.00%> (+44.44%) ⬆️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dtinth dtinth changed the title Add tests for internet ranking Add tests for Bemuse Online Ranking Nov 6, 2022
@dtinth dtinth added the c:ready label Nov 6, 2022
@dtinth dtinth changed the title Add tests for Bemuse Online Ranking Migrate to new scoreboard Nov 26, 2022
@sonarcloud
Copy link

sonarcloud bot commented Nov 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dtinth dtinth merged commit 41ada79 into master Nov 28, 2022
dtinth added a commit that referenced this pull request Nov 28, 2022
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 9d62b30f..72fa8670 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -39,9 +39,8 @@
   reset.** Please reset your password by specifying a blank password when
   logging in. [#785], by [@dtinth]

-[#785]: #785
-
-## v53.0.0-pre.202211281820
+- Added support for `.flac` keysounds in custom songs. Note that this only works
+  on browsers that natively support FLAC files. [#786], by [@dtinth]

 ### Internals

@@ -49,13 +48,10 @@
   thanks to [MikuroXina](https://github.com/MikuroXina) for making this happen!
   [#780], by [@MikuroXina]

-### Improvements
-
-- Added support for `.flac` keysounds in custom songs. Note that this only works
-  on browsers that natively support FLAC files. [#786], by [@dtinth]

 [#780]: #780
 [#786]: #786
+[#785]: #785

 ## v52.2.4 (2022-11-06)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants